? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
8 Nov 2015

Static scripts are way cooler

What does this PR fix?

Try this:
Select none as default editor for your current user
Then try to edit an article
Observe the source of the generated HTML page and you will find some inline scripts in the head and above textarea input

Testing

Apply this PR with patch tester and follow the above steps
A none.min.js is added in the header of the page
Make sure that the buttons bellow the editor still function as usual as well as the saving of the article

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar dgt41 dgt41 - open - 8 Nov 2015
avatar dgt41 dgt41 - change - 8 Nov 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 Nov 2015
Category JavaScript Plugins
avatar zero-24 zero-24 - change - 9 Nov 2015
Easy No Yes
avatar peterlose
peterlose - comment - 9 Nov 2015

Tested. Works fine :)

avatar zero-24 zero-24 - alter_testresult - 9 Nov 2015 - peterlose: Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 9 Nov 2015

I have tested this item :white_check_mark: successfully on dgt41@562d8cb

avatar RonakParmar
RonakParmar - comment - 10 Nov 2015

I have applied this patch and found "none.min.js" in article edit page source.
After reverted this patch "none.min.js" is not there in article edit page source. Successfully tested this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8342.

avatar zero-24 zero-24 - alter_testresult - 10 Nov 2015 - andrepereiradasilva: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 10 Nov 2015 - RonakParmar: Tested successfully
avatar zero-24 zero-24 - change - 10 Nov 2015
Milestone Added:
avatar zero-24 zero-24 - change - 10 Nov 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 10 Nov 2015

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8342.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 16 Nov 2015
Milestone Added:
avatar rdeutz rdeutz - change - 16 Nov 2015
Milestone Removed:
avatar rdeutz
rdeutz - comment - 16 Nov 2015

Moved to 3.5.1. because it is code cleanup and we don't merge this after beta

avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:00:03
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - reference | f1a8315 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment