Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8007] - Fixed the string comparison as it would fail in Windows.

? ? Success

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
3 Oct 2015

When running the unit tests on Windows, these assertions would fail because in the old situation it was looking for PHP_EOL which returns \r\n while the code is looking for \n.

Test instructions
Setup the Joomla test suite on your Windows system and run this test. You will get 3 failures. Apply the patch and the failures are gone.

avatar roland-d roland-d - open - 3 Oct 2015
avatar roland-d roland-d - change - 3 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 5 Oct 2015
Status Pending ⇒ Ready to Commit
avatar zero-24 zero-24 - change - 5 Oct 2015
Category ⇒ Unit Tests
avatar zero-24
zero-24 - comment - 5 Oct 2015

As Travis also is fine with it. --> RTC Thanks ;)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8007.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 5 Oct 2015
Milestone Added:
avatar mbabker mbabker - change - 5 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-05 13:41:12
Closed_By ⇒ mbabker
avatar mbabker mbabker - reference | 42c70fe - 5 Oct 15
avatar mbabker mbabker - merge - 5 Oct 2015
avatar mbabker mbabker - close - 5 Oct 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment