[#8008] - Clean and close the output buffer as it is no longer needed.
- Closed
- 6 Mar 2016
- Medium
- Build: staging
- Easy Test
- # 8008
- Diff
- roland-d:adapter_output_buffer
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When running the unit test, it would generate this error:
Test code or tested code did not (only) close its own output buffers
This error is generated because the triggerManifestScript() method would run into an error and then throws a RuntimeException without closing the output buffers which were opened. This change cleans and closes the output buffer as the output is not used anyway.
Test instructions
Only way I can see this tested is that you run the unit test and see the error, after applying the patch the error is gone.
Normal installation of an extension which fails should also still behave as usual.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries Unit Tests |
| Easy | No | ⇒ | Yes |
Check the screenshot, this is where I get these errors:
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-06 23:06:59 |
| Closed_By | ⇒ | wilsonge |
These were showing as Risky Tests on travis - hence why they were hidden. Merged
| Milestone |
Added: |
||
This seems right - but what unit test do you mean? I don't see anything in the travis output logs?