? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
3 Oct 2015

This pull request updates the error handling in the affected methods so that the return types match the method's documented return.

Testing Instructions

This one is borderline review only. In the case of the form fields, most of these cases are handled within the JForm API already and don't have public exposure. For the tags helper, you could probably do something that causes the query to fail and check the return type pre- and post- patch.

avatar mbabker mbabker - open - 3 Oct 2015
avatar mbabker mbabker - change - 3 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 5 Oct 2015
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 5 Oct 2015
Category Libraries
avatar zero-24
zero-24 - comment - 5 Oct 2015

Changes makes sense to me. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8006.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 5 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - change - 5 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-05 13:57:35
Closed_By rdeutz
avatar rdeutz rdeutz - close - 5 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 5 Oct 2015
avatar rdeutz rdeutz - reference | c3298b4 - 5 Oct 15
avatar rdeutz rdeutz - merge - 5 Oct 2015
avatar rdeutz rdeutz - close - 5 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Removed: ?
avatar mbabker mbabker - head_ref_deleted - 5 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment