? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
3 Oct 2015

This pull requests makes some improvements to the handling of Exceptions in the libraries folder.

In places where we are catching an Exception and throwing a new one, the new Exception will now include the previously caught Exception using the Exception API's ability to chain Exception objects.

Additionally, there were a couple of places where we were catching an Exception object and simply rethrowing it without any other processing, those places no longer catch Exceptions.

Minor doc block changes are included here.

Testing Instructions

This patch is a "needs review only" patch. There isn't a feasible way to write code that tests every one of these exception cases for the adjusted handling.

avatar mbabker mbabker - open - 3 Oct 2015
avatar mbabker mbabker - change - 3 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 5 Oct 2015
Category Libraries
avatar zero-24 zero-24 - change - 5 Oct 2015
Status Pending Needs Review
avatar zero-24
zero-24 - comment - 5 Oct 2015

Thanks moving to Needs Review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8005.

avatar wilsonge
wilsonge - comment - 8 Oct 2015

Reviewed exception changes successfully. Merging

avatar wilsonge wilsonge - change - 8 Oct 2015
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2015-10-08 23:36:31
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Oct 2015
avatar wilsonge wilsonge - reference | e59ae1d - 8 Oct 15
avatar wilsonge wilsonge - merge - 8 Oct 2015
avatar wilsonge wilsonge - close - 8 Oct 2015
avatar wilsonge wilsonge - change - 8 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment