? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
16 Aug 2015

This PR moves Filters from left sidebar to Search Tools.

Testing instructions

Before this PR

Extensions > Manage > Update Sites
1. Left sidebar has 4 filter options (Select: Location, Status, Type, Folder) that cannot be reset easily to original state with one button.

extension-updatesites-before

After this PR

Extensions > Manage > Update Sites
1. The Filters have been moved from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button.

extension-updatesites-after

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar pe7er pe7er - open - 16 Aug 2015
avatar pe7er pe7er - change - 16 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 16 Aug 2015

SQL error solved

I just ran into an SQL error. I triggered the error after I implemented the Search Tools with Filters, by navigating to another page and than back to Extensions > Manage > Update Sites.
extension-updatesites-error
I solved it by adding
$this->setState('list.ordering', 'name');
to the protected function populateState($ordering = null, $direction = null) method of the Updatesites model.

avatar zero-24 zero-24 - change - 17 Aug 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 17 Aug 2015
Easy No Yes
avatar timhaeuser timhaeuser - test_item - 20 Aug 2015 - Tested successfully
avatar timhaeuser
timhaeuser - comment - 20 Aug 2015

tested & works !


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7707.

avatar hitchblade hitchblade - test_item - 20 Aug 2015 - Tested successfully
avatar kesh52 kesh52 - test_item - 20 Aug 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 23 Aug 2015

@pe7er can you resolve the merge conflicts?

avatar pe7er
pe7er - comment - 26 Aug 2015

merge conflict solved: I removed the code for JHtmlSidebar::addFilter that was no longer needed.

avatar pe7er
pe7er - comment - 26 Aug 2015

Thanks for the codestyle changes! @zero-24

avatar zero-24 zero-24 - change - 26 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 26 Aug 2015

RTC based on testing Thanks @pe7er


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7707.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 26 Aug 2015
Milestone Added:
avatar bullet64
bullet64 - comment - 29 Aug 2015

tested & no errors found.

avatar wilsonge wilsonge - change - 23 Sep 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Sep 2015
Labels Removed: ?
avatar zero-24
zero-24 - comment - 2 Nov 2015

@pe7er I'm sad to say we run again in merge conflicts.

avatar pe7er
pe7er - comment - 3 Nov 2015

Please see new PR #8264 to replace this one.

avatar pe7er pe7er - change - 3 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-03 22:21:24
Closed_By pe7er
avatar pe7er pe7er - close - 3 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 3 Nov 2015
avatar pe7er pe7er - close - 3 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 4 Nov 2015
Milestone Removed:
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment