Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7706] - com_installer Manage - Moved sidebar Filters to Search Tools

? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
16 Aug 2015

This PR moves Filters from left sidebar to Search Tools.

Testing instructions

Before this PR

Extensions > Manage > Manage
1. Left sidebar has 4 filter options (Select: Location, Status, Type, Folder) that cannot be reset easily to original state with one button.

extension-manage-before

After this PR

Extensions > Manage > Manage
1. The Filters have been moved from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button.

extension-manage-after

Technical notes

  1. During development I got the following SQL error:
    Error - Unknown column "Array" in "order clause" SQL=SELECT ,2protected+(1-protected)*enabled as status FROM test_extensions WHERE state=0 ORDER BY Array ASC LIMIT 0, 20
    I fixed it in administrator/components/com_installer/models/manage.php in the method
    protected function populateState($ordering = null, $direction = null)
    I added this line: $this->setState('list.ordering', 'name');

  2. To get the correct list of installer types, I had to add JText to the helper file administrator/components/com_installer/helpers/installer.php in the method
    public static function getExtensionTypes()

Please triple double check if these two changes did not break anything anywhere else

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
1.00
avatar pe7er pe7er - open - 16 Aug 2015
avatar pe7er pe7er - change - 16 Aug 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Aug 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 17 Aug 2015
Easy No ⇒ Yes
avatar pe7er pe7er - reference | b6ce46b - 17 Aug 15
avatar hitchblade hitchblade - test_item - 20 Aug 2015 - Tested successfully
avatar kesh52 kesh52 - test_item - 20 Aug 2015 - Tested successfully
avatar zero-24 zero-24 - change - 26 Aug 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 26 Aug 2015

RTC based on the tests by @hitchblade & @kesh52

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7706.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 26 Aug 2015

Thanks for testing! @hitchblade & @kesh52

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7706.

avatar zero-24 zero-24 - change - 26 Aug 2015
Milestone Added:
avatar roland-d roland-d - reference | f92dfd4 - 24 Oct 15
avatar roland-d
roland-d - comment - 24 Oct 2015

Thanks everybody. Merged into 3.5-dev with commit f92dfd4

avatar roland-d roland-d - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar roland-d roland-d - close - 24 Oct 2015
avatar roland-d roland-d - change - 24 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-24 12:27:09
Closed_By ⇒ roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment