? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
16 Aug 2015

This PR moves Filters from left sidebar to Search Tools.

Testing instructions

Before this PR

Extensions > Modules
1. Left sidebar has 6 Filter options that cannot be reset easily
2. Middle column has 2 Ordering Filters. Ordering of the list can be accomplished by clicking the column headers.

com_modules_before

After this PR

Extensions > Modules
1. The Filters have been moved from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button.
2. Sidebar has been remove
3. The 2 Ordering options in the middle (Sort Table by + Select the ordering) have been removed. The admin can still order the results & determine the ordering direction by clicking on a column header (fieldname). Same options with less option boxes = IMHO more user friendly.

com_modules_after

Technical note

To get all filters in Search Options working, I had to add = null to two parameters in the Modules helper file /administrator/components/com_modules/helpers/modules.php
public static function getPositions($clientId = null, $editPositions = false)
public static function getModules($clientId = null)
Please triple double check if this change did not break anything anywhere else

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar pe7er pe7er - open - 16 Aug 2015
avatar pe7er pe7er - change - 16 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Aug 2015
Easy No Yes
avatar zero-24 zero-24 - change - 17 Aug 2015
Category Administration UI/UX
avatar pe7er pe7er - reference | 2508cb0 - 17 Aug 15
avatar hitchblade hitchblade - test_item - 20 Aug 2015 - Tested successfully
avatar kesh52 kesh52 - test_item - 20 Aug 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 26 Aug 2015

@pe7er can you resolve the merge conflicts?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7705.

avatar pe7er
pe7er - comment - 26 Aug 2015

Merge conflict fixed...

avatar zero-24 zero-24 - change - 26 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 26 Aug 2015

Thanks RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7705.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 26 Aug 2015
Milestone Added:
avatar pe7er
pe7er - comment - 26 Aug 2015

Travis did not like this PR regarding PHP 5.6 (he's happy with 5.3 to 5.5).
I don't understand the problem. Can someone correct this error? Thanks!

avatar zero-24
zero-24 - comment - 26 Aug 2015

Travis did not like this PR regarding PHP 5.6 (he's happy with 5.3 to 5.5).

Just beacause of a seccond change ;)

Catching of the expeced result was at: 2015-08-26 09:22:05 and the actual result is 2015-08-26 09:22:06

So all is good here. I try to bring it up to the Unit Tester Group to find a better way to test.

avatar pe7er
pe7er - comment - 26 Aug 2015

Ok, thanks @zero-24

avatar mbabker
mbabker - comment - 26 Aug 2015

I know PHPUnit has a way to test values with a variance for pure integers, I don't know if it can do the same natively for date/time values. Either way I'd call that a fluke (and re-ran the job). Definitely something to dig into though.

avatar infograf768
infograf768 - comment - 27 Aug 2015

@pe7er

Could you make a list of all the language strings that became obsolete in your various recent patches?
We can't take the strings out now as the lang packs may be used in older J version but this will be useful for J! 4 in order to take them off.
@Bakual
Maybe create a specific github repository where these will be available for the future?

avatar Bakual
Bakual - comment - 27 Aug 2015

Maybe create a specific github repository where these will be available for the future?

Why would you want to make them available separately? They will stay in J3 until it's EOL, and in J4 they will be removed. So they will be available in the 3.x branch/latest release.
Similar to how the 2.5.x branch is still available.

avatar infograf768
infograf768 - comment - 27 Aug 2015

It is not to make them available, just the opposite.
The reason is that it will be easier to delete all these when 4.0 is prepared.
Keep trace of all these easily.

avatar Bakual
Bakual - comment - 27 Aug 2015

I would rather add a deprecate notice to the string into the file itself.

I found out that when we add them after the string like this:
COM_FOO_BAR="Bar" ; This string is deprecated and will be removed with Joomla 4.0
Then it will even show up in translation tools like Crowdin (and probably also Transifex). Which means newly created language packs could actually skip translating those.

avatar Bakual
Bakual - comment - 27 Aug 2015

I hope someone also tested this on Hathor :smile:

avatar infograf768
infograf768 - comment - 27 Aug 2015

It would be much easier to have a list of all obsolete strings per file, just delete them in en-GB when we get to 4.0 and let TTs delete them the way they wish (I know that, for me, it will be much easier to delete manually with BBEdit than with any app including com_localise.)

Also

I found out that when we add them after the string like this:
COM_FOO_BAR="Bar" ; This string is deprecated and will be removed with Joomla 4.0

This would mark the file as errored in com_localise. When using comments, they should be on their own line.

avatar Bakual
Bakual - comment - 27 Aug 2015

It would be much easier to have a list of all obsolete strings per file, just delete them in en-GB when we get to 4.0 and let TTs delete them the way they wish (I know that, for me, it will be much easier to delete manually with BBEdit than with any app including com_localise.)

It may be easier for manual workflows, but it's much more work for the maintainers.
Also tools like Crowdin and Transifex will remove them automatically if we remove them in source.

This would mark the file as errored in com_localise. When using comments, they should be on their own line.

Joomla doesn't has a problem with it and com_localise can be adjusted.

avatar bertmert
bertmert - comment - 15 Sep 2015

So, this one should be closed.
#6958

avatar pe7er
pe7er - comment - 29 Oct 2015

Thanks @bertmert. This one can be closed now...

avatar pe7er pe7er - change - 29 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-29 23:13:24
Closed_By pe7er
avatar pe7er pe7er - close - 29 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 29 Oct 2015
avatar pe7er pe7er - close - 29 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 30 Oct 2015
Milestone Removed:
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment