[#7708] - com_users User Notes - Moved sidebar Filters to STools
- Closed
- 4 Nov 2015
- Medium
- Build: staging
- Easy Test
- # 7708
- Diff
- pe7er:search-tools-filters-usernotes
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR moves Filters from left sidebar to Search Tools.
Testing instructions
Before this PR
Users > User Notes
1. Left sidebar has 2 filter options (Select: Status, Category) that cannot be reset easily to original state with one button.
2. On the top right there are two duplicate ordering fields: "Sort Table By" & "Select the ordering" (for the direction of the ordering).
After this PR
Users > User Notes
1. the Filters from sidebar should be moved to the middle under "Search Tools" option. All filters can be reset with the "Clear" button.
2. the "Sort Table By" & "Select the ordering" have been removed. The ordering field + ordering direction can be set by clicking on a column header (fieldname).
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration UI/UX |
hitchblade
- 
I have an issue like by watchfulli-dev.
If I filter by status and need only "Unpublished" items, all items are displayed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
Thank you for testing @watchfulli-dev & @kesh52 !
I was able to reproduce the issue you both reported & corrected it in my patch.
Now the Status filter should work correctly...
Hello, i have installed the patch but i have issues.
I have created 4 user-notes.
- published
- unpublished
- trashed
- archived
Filter all - works
Filter published - shows published & unpublished
Filter trashed - ok
Filter archived - ok
I have the same as @bullet64. Published and unpublished shows the same thing.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
This PR has received new commits.
CC: @hitchblade, @kesh52, @watchfulli-dev
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
Thank you @bullet64 @YouriiM26 for testing & reporting the problem.
I've fixed it with a new patch.
I have tested this item 
successfully on a9bce89
The new patch worked for me. The published and unpublished aren't the same anymore. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
I have tested this item successfully on a9bce89
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
| Status | Pending | ⇒ | Ready to Commit |
RTC for 3.5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Needs Review |
| Labels | |||
| Labels |
Removed:
?
|
||
@Kubik-Rubik Thanks! I know about not removing the ordering fields.
I corrected that in some other PRs I did list night.
I'll correct it in this patch too...
This PR has received new commits.
CC: @hitchblade, @kesh52, @RemcoJanssen, @watchfulli-dev, @YouriiM26
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
I've corrected the PR to add the ordering fields back (via the filter_notes.xml that is used by Search Tools)
I have tested this item successfully on 78f1f4f
Works as described. Thank you @pe7er!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
I have tested this item successfully on 78f1f4f
Small note here: there is no ordering option so no drag and drop to reorder. maybe in another PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
@Kubik-Rubik this gets tested twice please do the final review and move to RTC if ok ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
| Status | Needs Review | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @dgt41, @hitchblade, @kesh52, @Kubik-Rubik, @RemcoJanssen, @watchfulli-dev, @YouriiM26
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-04 22:52:51 |
| Closed_By | ⇒ | pe7er |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
@test after applying the patch the top right ordering option is removed, and the filters from the left side are moved inside "Search tools" on top, but now seams the filters are not working, for example if I try to filter them by "Trashed" items, the published user note is still displayed after applying the filter
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7708.