[#7560] - Add Bootstrap3 class names to debug plugin
- Closed
- 29 Jul 2015
- Medium
- Build: staging
- # 7560
- Diff
- stiplady:debug-bootstrap3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Breaking changes were made between Bootstrap2.x and 3.0, http://getbootstrap.com/migration/
This commit adds the required changes to allow the debug panels to be useful when used with Bootstrap3 templates.
Bootstrap 2.x class names still intact for anyone still using Bootstrap 2.x
Test instructions:
Use a bootstrap 3 template
Enable debug in site configuration
View profile information
- Without this commit some of the labels and progress bars will be missing a background colour
- With this commit the labels and progress bars will be displayed with background colour
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
+1
+1
Bear
On 7/27/2015 12:46, Jelle Kok wrote:
+1
—
Reply to this email directly or view it on GitHub
#7560 (comment).No virus found in this message.
Checked by AVG - www.avg.com http://www.avg.com
Version: 2015.0.6081 / Virus Database: 4392/10319 - Release Date: 07/27/15
You need to fix codestyle issue for Travis to pass:
FILE: /home/travis/build/joomla/joomla-cms/plugins/system/debug/debug.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
934 | WARNING | Line exceeds 150 characters; contains 156 characters
That's a great improvement and I have tested too. It works as expected.
Yeah need to take care of code style issue. :-/
| Category | ⇒ | Templates (admin) |
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7560.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-29 06:10:09 |
| Closed_By | ⇒ | Bakual |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
I know that the vast majority of commercial templates already use BS3 and this benefits all those template users today and without any appreciable detrimental affects to those using BS2.3.x templates, as there seem to be no css clashes.
Test successful; profile information in debug console is now useful again! Tested against Protostar and custom templates using BS3.2.1 and 3.2.2.