Feeling Lucky
?
[#7559] - Code style fix
- Closed
- 27 Jul 2015
- Medium
- Build: staging
- # 7559
- Diff
- photodude:patch-5
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
- Fix lower case use of AS
- Put each item on their own line
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
RickR2H
- comment
- 27 Jul 2015
Works and makes the code much cleaner
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7559.
photodude
- comment
- 27 Jul 2015
@Bakual It's not directly addressed in the written portion of the Joomla coding style, But since we comply to many aspects of PSR-2 with some deviations; I choose to follow the explanation for multiple lines in the method and function calls.
Argument lists MAY be split across multiple lines, where each subsequent line is indented once.
When doing so, the first item in the list MUST be on the next line,
and there MUST be only one argument per line.
As @RickR2H said, "it sure makes the code more readable...", I think that's a good thing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-27 12:33:14 |
| Closed_By | ⇒ | Bakual |
wilsonge
- | Milestone |
Added: |
||
I'm not aware of a CS rule to have each field on its own line. There is only one for very long lines, which shouldn't be the case here.