[#7561] - Add Bootstrap Styling to Joomla Update Confirmation Message
- Closed
- 2 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7561
- Diff
- justinherrin:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is to add Bootstrap styling to the "successfully updated" confirmation message after updating Joomla via com_joomlaupdate.
Before Change
After Change
How to Test
- Implement the
class="alert alert-success"addition. - Visit administrator/index.php?option=com_joomlaupdate&layout=complete in your browser.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Templates (admin) UI/UX |
@810 @smehrbrodt
Are those comments to say you like the idea of this PR or that you have tested it and it works.
If you have tested it and it works please dont forget to mark it as a successful test and it can be moved to Ready to Commit status
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7561.
Are those comments to say you like the idea of this PR or that you have tested it and it works.
I like the idea and the code looks good, but I haven't tested it. Does this simple change need to be tested?
Everything needs to be tested
On 1 August 2015 at 09:08, Samuel Mehrbrodt notifications@github.com
wrote:
Are those comments to say you like the idea of this PR or that you have
tested it and it works.I like the idea and the code looks good, but I haven't tested it. Does
this simple change need to be tested?—
Reply to this email directly or view it on GitHub
#7561 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@test +1
On Sat, Aug 1, 2015 at 1:18 AM -0700, "Brian Teeman" notifications@github.com wrote:
Everything needs to be tested
On 1 August 2015 at 09:08, Samuel Mehrbrodt notifications@github.com
wrote:
Are those comments to say you like the idea of this PR or that you have
tested it and it works.I like the idea and the code looks good, but I haven't tested it. Does
this simple change need to be tested?—
Reply to this email directly or view it on GitHub
#7561 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Reply to this email directly or view it on GitHub:
#7561 (comment)
Just a quick way for folks to test this...
- Implement the
class="alert alert-success"addition. - Visit administrator/index.php?option=com_joomlaupdate&layout=complete in your browser.
fine here, can go RTC
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7561.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-02 14:40:38 |
| Closed_By | ⇒ | Bakual |
| Labels |
Removed:
?
|
||
Merged into staging. Thanks!
+1