? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
19 Jul 2015

Here is :bug: fix for IE8, that cause "Save" button do not work in Global configuration.

Test
Open Global configuration in IE8 and try save.
Actual result: nothing happens
Expected: form saved

avatar Fedik Fedik - open - 19 Jul 2015
avatar Fedik Fedik - change - 19 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 19 Jul 2015
Title
IE 8 Fix Global Configuration form submit 
IE 8 Fix Global Configuration form submit
avatar brianteeman brianteeman - change - 19 Jul 2015
Category JavaScript
avatar RickR2H
RickR2H - comment - 27 Jul 2015

Fix worked in IE8 Emulation mode!
for the next tester not knowing how to emulate IE8, here is the documentation https://msdn.microsoft.com/en-us/library/dn255001(v=vs.85).aspx


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7468.

avatar RickR2H RickR2H - test_item - 27 Jul 2015 - Tested successfully
avatar waader
waader - comment - 27 Jul 2015

I am unable to replicate the problem under win xp with ie 8.0. When I change for example the "site name" it is saved with or without the patch.

avatar Fedik
Fedik - comment - 27 Jul 2015

@waader hm, strange, I found this bug on Win 8 in IE8 Emulation mode

avatar RickR2H
RickR2H - comment - 28 Jul 2015

I tested it on Windows 7 and IE8 emulation and can confirm the bug.

avatar Fedik
Fedik - comment - 28 Jul 2015

Any way, use setAttribute() more safe than direct assignment, in this case.
Even jQuery warn about such problem http://api.jquery.com/prop/ :

Attempting to change the type property (or attribute) of an input element created via HTML or already in an HTML document will result in an error being thrown by Internet Explorer 6, 7, or 8.

So if for @waader this patch still work then I would count it as success test :wink:

avatar AnneKlapwijk AnneKlapwijk - test_item - 15 Apr 2016 - Tested successfully
avatar AnneKlapwijk
AnneKlapwijk - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 7d81098

Successfully reproduced the issue in IE8.
After applying the patch, the 'Save' button worked and the form was saved.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7468.

avatar Iclamer Iclamer - test_item - 15 Apr 2016 - Tested successfully
avatar Iclamer
Iclamer - comment - 15 Apr 2016

I have tested this item :white_check_mark: successfully on 7d81098

Successfully reproduced the issue in IE8.
After applying the patch, the 'Save' button worked and the form was saved.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7468.

avatar brianteeman brianteeman - change - 15 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7468.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 15 Apr 2016

@Fedik could you have a look at the merge conflicts, thanks.

avatar rdeutz rdeutz - change - 15 Apr 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Apr 2016

This PR has received new commits.

CC: @AnneKlapwijk, @Iclamer, @RickR2H


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7468.

avatar Fedik
Fedik - comment - 15 Apr 2016

good old problem with merging the minified script version :smile:

avatar rdeutz rdeutz - change - 15 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-15 18:43:55
Closed_By rdeutz
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Apr 2016
avatar rdeutz rdeutz - reference | 1eb89fc - 15 Apr 16
avatar rdeutz rdeutz - merge - 15 Apr 2016
avatar rdeutz rdeutz - close - 15 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2016
Labels Removed: ?
avatar Fedik Fedik - head_ref_deleted - 15 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment