Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7278] - Make HTML structure consistent for Joomla.renderMessages() (Fix #5602)

? Success
Pull Request for # 5602

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
27 Jun 2015

The original issue report noted an incorrect HTML structure based on the PHP based rendering. Since the initial report, the JavaScript handling has changed and the inner div with the system-message ID removed. This PR should make the HTML rendered by the JS consistent with the PHP layout.

Test Instructions

Honestly, I don't remember where in Joomla we render messages by JavaScript. But, the rendered HTML should be consistent with the HTML in the layout file specified in the initial issue.

avatar mbabker mbabker - open - 27 Jun 2015
avatar mbabker mbabker - change - 27 Jun 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 27 Jun 2015
Category ⇒ JavaScript
avatar zero-24 zero-24 - change - 27 Jun 2015
Rel_Number 0 ⇒ 5602
Relation Type ⇒ Pull Request for
Easy No ⇒ Yes
avatar Bakual
Bakual - comment - 27 Jun 2015

I'd say we use it in the CMS Installation and maybe with the JavaScript form validating

avatar zero-24
zero-24 - comment - 27 Jun 2015

tested successfull.

without the patch

screen shot 2015-06-27 at 16 24 49

with the patch

screen shot 2015-06-27 at 16 24 48

How I test

  • go to forgot password page
  • press submit without entering anything
  • see the sourcecode (using the Browser developer tools)
  • see the without patch structure
  • apply the patch
  • clear the cache (!!)
  • go to forgot password page
  • press submit without entering anything
  • see the sourcecode (using the Browser developer tools)
  • see the with patch structure
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7278.
avatar zero-24 zero-24 - test_item - 27 Jun 2015 - Tested successfully
avatar jwaisner
jwaisner - comment - 28 Jun 2015

@test

Test successful with patch. Functionality remains and code change implemented.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7278.

avatar jwaisner jwaisner - test_item - 28 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 28 Jun 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 28 Jun 2015

RTC :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7278.

avatar zero-24 zero-24 - change - 28 Jun 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 29 Jun 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - close - 3 Jul 2015
avatar mbabker mbabker - close - 3 Jul 2015
avatar mbabker mbabker - change - 3 Jul 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-07-03 10:00:47
Closed_By ⇒ mbabker
avatar mbabker mbabker - close - 3 Jul 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Jul 2015

Thank you @mbabker! Merged.

avatar mbabker mbabker - head_ref_deleted - 3 Jul 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment