Feeling Lucky
?
[#7277] - JFormFieldEditor does not pass columns value (Fix #5209)
- Closed
- 3 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7277
- Diff
- mbabker:fix5209
- Success The Travis CI build passed Details
Pull Request for
# 5209
User tests: Successful: Unsuccessful:
See #5209 for issue details.
Steps to reproduce the issue
Create form with
<field name='description'
type="editor"
cols="5"
rows="5"
label='COM_NKCOMP_FIELD_GROUPTARGET_LABEL'
description='COM_NKCOMP_FIELD_DESC'
required="true"
buttons="false"
filter="JComponentHelper::filterText"
/>
When rendered in components administration view, the value for the attribute "cols" is not shown in the HTML output for the according textarea element.
Expected result
Value for cols should be passed to HTML-Element.
Actual result
Empty attribute in HTML-Element textarea: cols=""
System information (as much as possible)
Linux, Apache2, php 5.4
Additional comments
traced it down to libraries/cms/form/field/editor/editor.php line 249:
249c249
< $this->name, htmlspecialchars($this->value, ENT_COMPAT, 'UTF-8'), $this->width, $this->height, $this->cols, $this->rows,
---
> $this->name, htmlspecialchars($this->value, ENT_COMPAT, 'UTF-8'), $this->width, $this->height, $this->columns, $this->rows,
In JFormFieldTextarea is no class variable "cols" but a class variable "columns".
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Rel_Number | 0 | ⇒ | 5209 |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
jwaisner
- comment
- 28 Jun 2015
PR works as intended.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7277.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 28 Jun 2015
| Labels |
Added:
?
|
||
photodude
- comment
- 29 Jun 2015
Looks like the php5.5 travis CI test needs to be re-run.
Kubik-Rubik
- comment
- 29 Jun 2015
@photodude Thanks, I've restarted the job at Travis.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-03 10:07:49 |
| Closed_By | ⇒ | mbabker |
| Labels |
Removed:
?
|
||
tested successful. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7277.