? Success
Pull Request for # 6807

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
22 Jun 2015

Issue

Described in #6807 - script is loaded based on current protocol causing issues when caching is enabled (if you switch from http to https the cached page still uses http for script inclusion and thus the browser is blocking it).

Solution

I see no problem in loading it using https all the time. I've also found that &render=explicit is not properly URL encoded and fixed that as well.

avatar OctavianC OctavianC - open - 22 Jun 2015
avatar OctavianC OctavianC - change - 22 Jun 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 22 Jun 2015

Change is good. Please remove whitespaces in line 60!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7237.

avatar Kubik-Rubik Kubik-Rubik - test_item - 22 Jun 2015 - Tested successfully
avatar OctavianC
OctavianC - comment - 22 Jun 2015

Sorry, my editor does that automatically :)

avatar zero-24 zero-24 - change - 22 Jun 2015
Category Plugins
avatar zero-24 zero-24 - change - 22 Jun 2015
Rel_Number 0 6807
Relation Type Pull Request for
Easy No Yes
avatar 810
810 - comment - 22 Jun 2015

@test +1

avatar Kubik-Rubik Kubik-Rubik - alter_testresult - 23 Jun 2015 - 810: Tested successfully
avatar Kubik-Rubik Kubik-Rubik - change - 23 Jun 2015
Status Pending Ready to Commit
avatar Kubik-Rubik Kubik-Rubik - change - 23 Jun 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Jul 2015

Thank you @OctavianC! Merged.

avatar zero-24 zero-24 - close - 3 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - change - 3 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-03 12:26:54
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 3 Jul 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment