[#7238] - Allows to specify relative protocol URIs in JHtml()
- Closed
- 22 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 7238
- Diff
- OctavianC:relative-url-scripts
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue
While working on #7237 I noticed that you cannot specify relative protocol URIs (description here) when using JHtml() to load external scripts or stylesheets.
If you try to use something along the lines of:
JHtml::_('script', '//www.google.com/recaptcha/api.js');The file will get ignored completely (it won't show up in the <head> section).
Solution
includeRelativeFiles() from the JHtml class seems to take into account external files only if they begin with http. Added another check for // and fixed the issue. Or added a new feature, whichever you prefer :)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Done, no idea why Travis is failing though :(
Looks good for me now, Travis timed out in one of the processes (10 minutes no output).
Restarted the errored Travis jobs. Hopefully they will pass now.
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Libraries |
bump - Travis job seems ok.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-22 12:48:47 |
| Closed_By | ⇒ | mbabker |
Good change, had the issue also in combination with a CDN service.
@OctavianC Please also update the comment above the changed line. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7238.