[#7236] - Implementing "No Matching Results" in Users modal
- Closed
- 3 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 7236
- Diff
- brianteeman:usermodal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In the article manage when selecting a User in the publishing tab the list of users is displayed in a modal window.
When filtering and if no results, the display is just empty instead of the usual message "No Matching Results"
This patch is just implementing the message in the modal when necessary.
Thanks to @infograf768 for the code idea
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration UI/UX |
| Easy | No | ⇒ | Yes |
@brianteeman You have to move all lines in the code section one indent to the right, so that the opening and ending tags are in the same row (e.g. thead is not in the same row). Thanks!
Sorry not got a clue what you mean
Please create a PR against my branch so that I can see what you mean
(BTW I think you are confusing row and column)
On 23 June 2015 at 12:36, Viktor Vogel notifications@github.com wrote:
@brianteeman https://github.com/brianteeman You have to move all lines
in the code section one indent to the right, so that the opening and ending
tags are in the same row (e.g. thead is not in the same row). Thanks!—
Reply to this email directly or view it on GitHub
#7236 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman Sorry, I meant column of course. Okay, I will send you a PR soon. :-)
Thank you, @brianteeman and @infograf768!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7236.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Thank you @brianteeman! Merged.
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-03 12:34:20 |
| Closed_By | ⇒ | brianteeman |
| Labels |
Removed:
?
|
||
OK here.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7236.