[#7235] - Fixes HTML errors in com_installer #7230
- Closed
- 1 Sep 2015
- Medium
- Build: staging
- Easy Test
- # 7235
- Diff
- OctavianC:fix-html-com-installer
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is just a small fix for the missing closing tags mentioned in #7230. You won't be able to see any visual changes since browsers were already suppressing the errors.
Locations fixed:
- Extensions > Extension Manager > Install (missing closing
</div>tag for<div id="j-main-container">) - Extensions > Extension Manager > Database (missing closing
</div>for<div class="tab-content" id="myTabContent">and</li>for<li>No default text filters found.)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Easy | No | ⇒ | Yes |
Waiting on Travis (I'm sure I got some CS issues), but here's what I did:
- Changed Javascript alerts to use
Joomla.JText._() - Moved
<form>inside#j-main-container - Added some more spacing in the code to understand what's going on :)
- The close link on the JED Installer alert wasn't properly escaped
- The tooltip had a str_replace for
"into", better use$this->escape()if you don't trust the language key - Changed buttons to use
<button>instead of<input> - Wanted to change the
myTabID but it seems to be hard-coded in thewebinstallerplugin so leaving that like it is for now - Noticed that images from
media/juiare not following theimages/naming convention, instead they're inimg/. I've movedajax-loader.giftomedia/jui/imagesso that it can be overwritten by the template. I don't see any other place where this is used so I though it's alright. - Removed inline styling for
.j-jed-message - Added styling for
#loadingdiv and no longer rely on Javascript to create it
Looks great! 
Only two travis errors.
@test works fine for me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7235.
Good testing instructions are missing.
To test open the following files and check for the missing divs. A good IDE will point them out.
administrator\components\com_installer\views\database\tmpl\default.php
On line 103: Starting div without closing div
administrator\components\com_installer\views\install\tmpl\default.php
On line 20: Starting div without closing div
On line 40: Starting li without closing li
After applying the test the missing html tags are added.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7235.
PR works as intended and missing code is added.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7235.
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7235.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Thank you @OctavianC! Merged with 87db28b
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-09-01 19:38:48 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Nota bene: This PR introduced 2 regressions:
- No Joomla-spindle during extensions installations. Fix proposal is in PR #9144
- No Joomla-spindle anymore in Install-from-web browsing. Fixed with Install-from-web 1.1.0, released today for Joomla 3.5 (and in 1-2 weeks for Joomla 3.4 too)
Looks good to me.
But maybe we can make the alignment in
administrator/components/com_installer/views/install/tmpl/default.phpa little bit better?For example the
divabove theform. We can add tabs right there. Also on line 119 the tab alignment isn't fully correct.Good idea?