Joomla! Issue Tracker | Joomla! CMS #7180 - # fix for #7178

Closed
16 Jun 2015
Medium
Build: staging
Easy Test
# 7180
Diff
compojoom:jfile

Success

Success The Travis CI build passed Details

Pull Request for # 7178

User tests: Successful: Unsuccessful:

compojoom
15 Jun 2015

Test by Using JFile::move with invalid $src parameter. Without the patch the function returns a string. With the patch it returns a boolean false. And the error is logged.

ab93c9e 15 Jun 2015

# fix for #7178 - JFile::move() returns a string

compojoom - open - 15 Jun 2015

zero-24 - change - 15 Jun 2015

Labels

Added: ?

zero-24 - change - 15 Jun 2015

how to test

add the following code to your template index.php (e.g. /JRoot/templates/protostar/index.php)
access the frontend (with the template active ;))
you will see something like this:
apply the patch using the patchtester:
- https://github.com/joomla-extensions/patchtester/releases/tag/2.0.0.beta3
- https://github.com/joomla-extensions/patchtester/blob/master/README.md
access the frontend again
the following screen should be displayed:
see the log file and notice the new entry
successful tested

TestCode for the template index.php

After line 10 / the defined('_JEXEC') or die; check

$src = '/temp/joomla/joomla.php';
$dest = '/temp/joomla2/joomla.php';

echo JFile::move($src, $dest);

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7180.}

zero-24 - test_item - 15 Jun 2015 - Tested successfully

zero-24 - change - 15 Jun 2015

Easy

⇒

Yes

zero-24 - change - 15 Jun 2015

Rel_Number	0	⇒	7178
Relation Type		⇒	Pull Request for

dgt41 - comment - 15 Jun 2015

@test ok

jwaisner - comment - 15 Jun 2015

@test

PR displays proper message after being applied.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7180.}

jwaisner - test_item - 15 Jun 2015 - Tested successfully

Bakual - change - 16 Jun 2015

Labels

Added: ?

Bakual - comment - 16 Jun 2015

Merged with a31283d

Thanks

Bakual - change - 16 Jun 2015

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2015-06-16 09:12:21
Closed_By		⇒	Bakual

Bakual - close - 16 Jun 2015

zero-24 - close - 16 Jun 2015

zero-24 - change - 14 Oct 2015

Labels

Removed: ?

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#7180] - # fix for #7178 - JFile::move() returns a string

how to test

TestCode for the template index.php

Add a Comment