Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7178] - JFile::move() returns a string, not a boolean:

?
Referenced as Pull Request for: # 7180
avatar compojoom
compojoom
15 Jun 2015

I just found out that JFile::move() actually returns a string whenever the file cannot be found. The doc comment states that it returns boolen. So my check if (JFile::move()) fails in some situations.
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filesystem/file.php#L252

What would be the correct way to fix this in your opinion? Log the message and return false. Or show the message with Japplication()->enqueueMessage?

avatar compojoom compojoom - open - 15 Jun 2015
avatar mbabker
mbabker - comment - 15 Jun 2015 
JLog::add(JText::_('JLIB_FILESYSTEM_CANNOT_FIND_SOURCE_FILE'), JLog::WARNING, 'jerror');

return false;
avatar zero-24 zero-24 - change - 15 Jun 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 15 Jun 2015

Closing as we have a Pull Request here: #7180

avatar zero-24 zero-24 - change - 15 Jun 2015
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-15 15:48:56
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 15 Jun 2015

Add a Comment

Login with GitHub to post a comment