Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7179] - Module list

? Success

User tests: Successful: Unsuccessful:

avatar astridx
astridx
15 Jun 2015

See the failure
1. Go to the Extensions | Module Manager and ensure, that you have at least two modules of the type banners for the location site. One is published and another is unpublished.
2. Switch to Extension Manager|Manage and disable the Modul “Banners” for the location site.
3. Go back to Extensions | Module Manager and see, that the Status show wrong values. The published Module looks like unpublished and the unpublished value looks like trashed.

Apply my patch
1. Go to the Extensions | Module Manager and ensure, that you have at least two modules of the type banners for the location site. One is published and another is unpublished.
2. Switch to Extension Manager|Manage and disable the Module “Banners” for the location site.
3. Go back to Extensions | Module Manager and see, that the Status did not show the wrong values any more. The Module with disabled extensions has no status.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00
avatar astridx astridx - open - 15 Jun 2015
avatar astridx
astridx - comment - 15 Jun 2015

Attachments
snap1
[Uploading snap2.jpg…]()
[Uploading snap3.jpg…]()

avatar astridx astridx - change - 15 Jun 2015
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-15 15:47:46
Closed_By ⇒ astridx
avatar astridx astridx - close - 15 Jun 2015
avatar joomla-cms-bot joomla-cms-bot - close - 15 Jun 2015
avatar astridx astridx - close - 15 Jun 2015
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 15 Jun 2015

@astridx why you close here?

avatar astridx
astridx - comment - 16 Jun 2015

I did not want to close here. This was a mistake. Is it possible to open this issue again?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7179.

avatar brianteeman brianteeman - change - 16 Jun 2015
Status Closed ⇒ New
Closed_Date 2015-06-15 15:47:46 ⇒
Closed_By astridx ⇒
avatar brianteeman brianteeman - reopen - 16 Jun 2015
avatar brianteeman brianteeman - reopen - 16 Jun 2015
avatar brianteeman
brianteeman - comment - 16 Jun 2015

Re-opened

avatar astridx
astridx - comment - 16 Jun 2015

@brianteeman
Thank you for reopening.

My suggestion is only a quick fix, so that no wrong values are shown any more.
I know, that it would be much better, to show a message, so that a user can see, that this extension is disabled. I work on this, but I like to make more experience in contributing for Joomla! Before I change more classes.

Here are text with the missing images:

See the failure
1. Go to the Extensions | Module Manager and ensure, that you have at least two modules of the type banners for the location site. One is published and another is unpublished.
screen shot 2015-06-16 at 02 18 37

  1. Switch to Extension Manager|Manage and disable the Modul “Banners” for the location site.
    screen shot 2015-06-16 at 02 18 37

  2. Go back to Extensions | Module Manager and see, that the Status show wrong values. The published Module looks like unpublished and the unpublished value looks like trashed.
    screen shot 2015-06-16 at 02 18 37

Apply my patch
1. Go to the Extensions | Module Manager and ensure, that you have at least two modules of the type banners for the location site. One is published and another is unpublished.
2. Switch to Extension Manager|Manage and disable the Module “Banners” for the location site.
3. Go back to Extensions | Module Manager and see, that the Status did not show the wrong values any more. The Module with disabled extensions has no status.
screen shot 2015-06-16 at 02 24 46

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7179.

avatar zero-24 zero-24 - change - 16 Jun 2015
Status New ⇒ Pending
avatar zero-24 zero-24 - change - 16 Jun 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 16 Jun 2015
Easy No ⇒ Yes
avatar MAT978
MAT978 - comment - 17 Jun 2015

able to reproduce then #7179 works as describe but I'm not sure about the solution with not showing status anymore...
thanks!

avatar MAT978 MAT978 - test_item - 17 Jun 2015 - Tested successfully
avatar Bakual
Bakual - comment - 17 Jun 2015

It sure needs some sort of icon with a tooltip explaining that the extension has been disabled. Otherwise it's very confusing that the icons are just missing.

avatar astridx
astridx - comment - 18 Jun 2015

Thank you very much for the test and the feedback.

I already wrote that I would prefer a solution with an error message, too.

Motivated by this feedback I am going to update this PR on the weekend and supply an icon.

How should I do this? Should I open a new PR and ask for closing this PR, or can I update this PR?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7179.

avatar Bakual
Bakual - comment - 18 Jun 2015

You can update this PR by just pushing new commits to this branch.
If you're using the GitHub UI, just select the appropriate branch in your fork before you start editing.

avatar zero-24
zero-24 - comment - 18 Jun 2015

or can I update this PR?

Yes you can update.

Github UI

via CLI. (generaly)

  • git checkout ModuleList
  • change the files
  • git commit -a -m 'The commit message (something meaningfull here please)'
  • git push origin ModuleList
  • github User and PW
  • fixed
avatar astridx astridx - change - 20 Jun 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-06-20 10:00:05
Closed_By ⇒ astridx
avatar astridx astridx - close - 20 Jun 2015
avatar astridx astridx - close - 20 Jun 2015
avatar astridx astridx - head_ref_deleted - 20 Jun 2015
avatar astridx astridx - head_ref_restored - 20 Jun 2015

Add a Comment

Login with GitHub to post a comment