[#6911] - Regression: Read More button doesn’t work any more...
- Closed
- 20 May 2015
- Medium
- Build: staging
- Easy Test
- # 6911
- Diff
- dgt41:_read_more_fix
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Restores read more button functionality
Response to #6909
The problem:
Create an article, add some text and try to insert a Read More via the Read More button.
The code
is not inserted.
After some tests with IE 8 & 11 and some reading on what changed in tinyMCE from 3.x to 4.x I removed the function IeCursorFix.
Test
With latest staging try to insert a read more tag (with the button bellow editor)
Apply patch and retry
This needs to be tested on ALL IE versions Joomla supports, thats 8,9,10 & 11 (and if you have it handy why not with edge). All other browsers are not affected, besides the fact that the code was replacing the onclick event of the buttons and therefore made them unusable!
| Title |
|
||||||
@infograf768 JM do you know if this IeCursorFix() is used for all versions of IE?
What is wrong with it? What can someone observe as an issue so that they
can test and replicate the issue and the fix
On 9 May 2015 at 11:45, Dimitris Grammatiko notifications@github.com
wrote:
Fix read more button
You can view, comment on, or merge this pull request online at:
#6911
Commit Summary
- fix
File Changes
- M plugins/editors/tinymce/tinymce.php https://github.com/joomla/joomla-cms/pull/6911/files#diff-0 (5)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/6911.patch
- https://github.com/joomla/joomla-cms/pull/6911.diff
—
Reply to this email directly or view it on GitHub
#6911.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman Sorry was too spartan in the comments! What is wrong? the button doesn’t apply any html to the editor window, or visually the red dotted line is not inserted...
| Title |
|
||||||
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
@infograf768 All buttons continue to function as expected here on IE8
The link is an article selected with the article button
| Title |
|
||||||
| Title |
|
||||||
@infograf768 If I force IeCursorFix() to run I get very strange behavior on IE: the text is white and the return will not change line.
So I think this is outdated code and we should completely take it out
zero-24
- | Category | ⇒ | JavaScript Plugins |
| Title |
|
||||||
| Status | New | ⇒ | Pending |
| Rel_Number | 0 | ⇒ | 6909 |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
As I do not have IE here, I can't test.
Please modify PR title to include "Regression" and change "Reader" button to "Read More" button. ;)
| Title |
|
||||||
| Title |
|
||||||
@roland-d Can you take a look at this one, as it is a release blocker for 3.4.2 since there is a regression that needs to be fixed!
The first two commits check if there is a value for onclick event on the buttons and if so doesn’t change it with the code IeCursorFix(); return false;.
The third commit has a another approach: the function IeCursorFix() is a fix for IE cursor position which (most probably) was needed in tinyMCE version 3. My tests (IE8 & IE11) indicate that the editor functions normally without this fix.
We need two tests with all IE versions Joomla support (>IE8), and thoroughly test all the functionality of the editor
| Milestone |
Added: |
||
I will owe you big time! Beers on me!
still needs testing on IE8
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-20 14:13:59 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@test OK here. Thank you! (but I do not use IE, so it may be necessary to check on IE)