? ? Success
Pull Request for # 6903

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
9 May 2015

Explanation

This PR adds the option to set where the module editing link is opened. The options are to open the link in the frontend or the backend. This is a PR for #6903

Test instructions

  1. In the adminstrator section go to System -> Global configuration
  2. On the Site tab set the option Mouse-over Edit Icons for to Modules or Modules & Menus
  3. Save the configuration
  4. Log in to the frontend of the site
  5. Go to a module and click on the edit link
  6. The module edit screen opens in the frontend
  7. Close the edit screen
  8. Apply the pull request
  9. In the administrator section go to Extensions -> Module manager
  10. Click on the Options button on the top right
  11. On the General tab set Edit module to Administrator
  12. Click on Save & close
  13. Go to the frontend of the site
  14. Refresh the page
  15. Go to a module and click on the edit link
  16. The module edit screen opens in the administrator section
  17. Test complete
avatar roland-d roland-d - open - 9 May 2015
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 9 May 2015

@test successful Thanks @roland-d expected the comment above. Great work!

avatar zero-24 zero-24 - change - 9 May 2015
Category Administration Front End Modules
avatar zero-24 zero-24 - change - 9 May 2015
Status New Pending
Easy No Yes
avatar roland-d
roland-d - comment - 9 May 2015

@zero-24 Good find, I fixed it. Thanks for the test.

avatar roland-d roland-d - change - 9 May 2015
Rel_Number 0 6903
Relation Type Pull Request for
avatar zero-24
zero-24 - comment - 9 May 2015

Great! So we need one more tester :smile:

avatar zero-24 zero-24 - test_item - 9 May 2015 - Tested successfully
avatar Dylis
Dylis - comment - 9 May 2015

@test Patch working as expected. Tested on quick search module.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6910.

avatar Dylis Dylis - test_item - 9 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 9 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 9 May 2015

Great. Thanks @Dylis I move this to RTC now!

avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar dgt41
dgt41 - comment - 9 May 2015

@test OK
One thing is that the option is way to difficult to be found. Can we add some text above or below the Mouse-over Edit Icons for Modules & Menus field to explain where this option can be found?

avatar zero-24
zero-24 - comment - 9 May 2015

@roland-d @dgt41

Agree maybe in the description text for the mouse over option?

avatar roland-d roland-d - change - 9 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-09 13:03:51
Closed_By roland-d
avatar roland-d roland-d - close - 9 May 2015
avatar roland-d roland-d - close - 9 May 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 9 May 2015

Thank you @roland-d for the contribution!

avatar Kubik-Rubik Kubik-Rubik - change - 9 May 2015
Milestone Added:
avatar roland-d roland-d - head_ref_deleted - 9 May 2015
avatar roland-d
roland-d - comment - 9 May 2015

@dgt41 I believe this should be in the documentation not in the code.

avatar dgt41
dgt41 - comment - 9 May 2015

@roland-d I will not argue on this! ???? Thanks!

avatar heiro
heiro - comment - 15 May 2015

Nice feature! Will it also be possible to edit menu items from frontend in the next version, not only modules? I mean to remember you could do that in J.3.3 with Protostar template.

avatar roland-d
roland-d - comment - 15 May 2015

@heiro I can make a separate pull request for that.

avatar heiro
heiro - comment - 15 May 2015

Great! It would be nice if that would work both when link is opened in frontend and in backend.

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment