Joomla! Issue Tracker | Joomla! CMS #6794 - Patch #6712

? ?

Fixed in Code Base
11 Sep 2016
Medium
Build: staging
# 6794
Diff
Devportobello:patch-6712

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

Pull Request for # 6712

User tests: Successful: Unsuccessful:

Devportobello
17 Apr 2015

Checkbox field does not allow defining a value without being checked
#6712

For easiest test use this custom component: https://github.com/Devportobello/joomla-attach-PR-6794

Test

First sry for my bad english, will try my best.

Dunno if we can test with something actually in Joomla, so if you want you can install my custom component then go to frontend "www.yourdomain.com/?option=com_test"

"with default" mean the attribute "value" of checkbox are set with something different that 1
"with group" mean the use of fields in xml form definition

Test1
Uncheck all checkbox then submit
-> Checkbox 1 with default and checkbox 2 with default are checked

Test2
Patch with the fix,
Uncheck all checkbox then submit
-> All checkbox are unchecked

DEV

JForm::loadField
-> $field->setup($element, $value, $group) with value = $value or $default
Then
JFormFieldCheckbox::setup
-> empty($this->value) || $this->checked ? null : $this->checked = true;

5256d86 17 Apr 2015

Patch 6712 - FieldCheckbox attribute default

Devportobello - open - 17 Apr 2015

7da00e5 17 Apr 2015

fix code style

Devportobello - change - 17 Apr 2015

Title

…

Patch 6712 - FieldCheckbox attribute default

Patch #6712 - FieldCheckbox attribute default

brianteeman - change - 22 Apr 2015

Rel_Number		⇒	6712
Relation Type		⇒	Pull Request for

zero-24 - change - 29 Apr 2015

Labels

Added: ?

zero-24 - change - 29 Apr 2015

Labels

Removed: ?

zero-24 - change - 29 Apr 2015

Labels

Added: ?

zero-24 - comment - 29 Apr 2015

@Devportobello sorry I'm not exactly sure what I need to test? Can you provide a step to step non technical testinstruktion? Thanks

zero-24 - change - 29 Apr 2015

Category

⇒

Libraries

zero-24 - change - 29 Apr 2015

Status

New

⇒

Pending

a3eb6b0 30 Apr 2015

Added a clean line

bertmert - comment - 7 May 2015

The goal is to have a checkbox that not just sends a value 0 or 1 if it's un/checked but an own value like somevalue.

Test instructions:

Download ZIP of com_test at https://github.com/Devportobello/joomla-attach-PR-6794
Install it.
Have a look into components/com_test/models/fields/test.xml if you want to.
Go to frontend home. Add /?option=com_test to URL.
You'll see 2 checkboxes already checked just because the form XML file has set default values to them like

default="somevalue"

. Expected: No checkbox is checked when you open com_test first time.

Uncheck both checkboxes. Check all other checkboxes. Click button.
All checkboxes are checked after reload but only 2 should be checked.
Apply patch: Test again.

But see also comment by @infograf768
#6712 (comment)
that fixes #6712 by using field type checkboxes instead of field type checkbox.

RonakParmar - test_item - 11 Jun 2016 - Tested successfully

RonakParmar - comment - 11 Jun 2016

I have tested this item ✅ successfully on a3eb6b0

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6794.}

conconnl - test_item - 25 Jun 2016 - Tested successfully

conconnl - comment - 25 Jun 2016

I have tested this item ✅ successfully on a3eb6b0

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6794.}

Before patch:

After patch:

zero-24 - change - 25 Jun 2016

Status

Pending

⇒

Ready to Commit

zero-24 - comment - 25 Jun 2016

RTC based on tests. Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6794.}

joomla-cms-bot - change - 25 Jun 2016

Labels

Added: ?