Feeling Lucky
?
?
[#6793] - Fix #5939 | XMLReader::read returns false on invalid xml and error in ph...
- Closed
- 7 Jun 2016
- Medium
- Build: staging
- # 6793
- Diff
- Achal-Aggarwal:fix-5939
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
...p3. Throw an exception and stop loop execution if feed xml is bad.
zero-24
- | Category | ⇒ | Libraries Unit Tests |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Information Required |
brianteeman
- comment
- 8 May 2016
Set status to Information Required.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6793.
brianteeman
- comment
- 7 Jun 2016
I am closing this at this time as it appears to have been resolved elsewhere and there has been no response to the comments. It can always b reopened if that is done.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6793.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-07 10:00:00 |
| Closed_By | ⇒ | brianteeman |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Is this still valid against current staging? https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/feed/factory.php#L66-L80
Exceptions aren't thrown by XMLReader so the try/catch is definitely redundant code but the do/while loop has changed since this PR.