? Success

User tests: Successful: Unsuccessful:

avatar sovainfo
sovainfo
18 Apr 2015

Removing indexes that are not needed.
This assumes the primary key is using type_id instead of type_alias. See #6748
The indexes on type_id and tag_id are redundant because of the other
indexes avialable. The index on tag-name (tag_id, type_alias) only
existed for MsSQL.

avatar sovainfo sovainfo - open - 18 Apr 2015
avatar zero-24 zero-24 - change - 29 Apr 2015
Category MS SQL Postgresql SQL
avatar zero-24 zero-24 - change - 29 Apr 2015
Status New Pending
avatar waader
waader - comment - 31 Aug 2015

Successfully tested with all databases.

avatar waader waader - test_item - 31 Aug 2015 - Tested successfully
avatar pos-it pos-it - test_item - 24 Oct 2015 - Tested successfully
avatar pos-it
pos-it - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on f23313f

Tested only on MySQL but there it works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6795.

avatar waader waader - test_item - 24 Oct 2015 - Tested successfully
avatar waader
waader - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on f23313f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6795.

avatar zero-24 zero-24 - change - 24 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 24 Oct 2015

RTC :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6795.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar roland-d
roland-d - comment - 25 Oct 2015

@sovainfo Can you please update this PR by renaming the SQL files to version 3.5.0 as this is the version they will be merged in. The date for the SQL files needs to be 2015-12-04 as that will be release date of 3.5.0. Thank you.

avatar mbabker
mbabker - comment - 25 Oct 2015

It doesn't NEED to be the date of release. Typically we've done it where it's the day it's merged in the past.

avatar joomla-cms-bot
joomla-cms-bot - comment - 25 Oct 2015

This PR has received new commits.

CC: @pos-it, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6795.

avatar sovainfo
sovainfo - comment - 25 Oct 2015

Changed the version to 3.5.0, don't understand why this bugfix is delayed to a minor update!
Kept the date as is, consider it absurd to predict the date upon creation of a fix!

Note that all three files are renamed using Github, despite it only shows one on the commit!

avatar roland-d roland-d - reference | 1542855 - 26 Oct 15
avatar roland-d
roland-d - comment - 26 Oct 2015

@sovainfo Very simple why it is delayed, second test didn't come in until 2 days ago.

Thanks everybody, merged with commit 1542855

avatar roland-d roland-d - close - 26 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 26 Oct 2015
avatar roland-d roland-d - close - 26 Oct 2015
avatar roland-d roland-d - change - 26 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-26 18:50:24
Closed_By roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2015
Labels Removed: ?
avatar sovainfo
sovainfo - comment - 26 Oct 2015

@roland-d That explains why it takes that long for bugfixes to get through. It doesn't explain why SemVer is not followed!

avatar Bakual
Bakual - comment - 26 Oct 2015

@sovainfo Actually, it doesn't matter at all in this case. 3.5.0 is expected to be the next release anyway.

avatar sovainfo
sovainfo - comment - 26 Oct 2015

It matters when you claim to be following SemVer. Current actions don't make sense. Why is there a milestone 3.4.6 ? What happens when 3.5 will be postponed again and 3.4.6, 3.4.7 and following will be released?

How hard can it be to really follow SemVer?

avatar mbabker
mbabker - comment - 26 Oct 2015

If we were following SemVer to the letter with zero deviation then 3.4.5 should have been 4.0.0, likewise 3.5.0 should be 4.0.0 (actually 5.0.0 had we incremented the major version correctly). Sometimes it's a judgement call and sometimes there is an intended plan that changes and causes things to go awry.

Add a Comment

Login with GitHub to post a comment