? Success
Related to # 5386

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
13 Apr 2015

This is similar to #5386

Use the bootstrap javascript for rendering the progress bar

bootstrap.framework is always loaded in ISIS and HATHOR so it’s better to use that library instead of loading one more script!

B/C

The html markup is changed
The relative js file is not loaded anymore

Testing

Try to install a 3.4 site apply this patch and then update it to 3.4.1 or the latest staging
Or if you are already on staging, do this:
Apply this PR
In the #__extensions table find the row with extension_id=700 and edit the manifest_cache field. Change the "version":"3.4.2-dev" part of it with "version":"3.4.0"
Edit the libraries/cms/version/version.php file and change public $DEV_LEVEL = '2-dev'; (your version may be different!) to public $DEV_LEVEL = '0';
Now login to administrator and update joomla!
You should see a progress bar like this:

screen shot 2015-04-19 at 7 18 43

This removes one more Mootools dependency, yay!

avatar dgt41 dgt41 - open - 13 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2015
The description was changed
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2015
Labels Added: ?
avatar dgt41 dgt41 - change - 13 Apr 2015
The description was changed
avatar dgt41 dgt41 - change - 13 Apr 2015
The description was changed
avatar dgt41 dgt41 - change - 14 Apr 2015
The description was changed
avatar dgt41 dgt41 - change - 14 Apr 2015
The description was changed
avatar dgt41 dgt41 - change - 14 Apr 2015
The description was changed
avatar dgt41
dgt41 - comment - 14 Apr 2015

@nikosdion Nikola can you take a look at this one, as I struggle to get the update.js to jquery as a 1 to 1 conversion and I don’t won’t to touch restore.php?
Thanks

avatar nikosdion
nikosdion - comment - 14 Apr 2015

If you find yourself in need to touch restore.php you are doing something extremely wrong! In fact, com_joomlaupdate's Javascript was backported from jQuery to mooTools when I contributed this feature. The newer version of the jQuery code is now part of Akeeba CMS Update and you can find it at https://github.com/akeeba/cmsupdate/blob/master/component/media/js/common.js

Please keep in mind that CMS Update uses a private copy of jQuery in the cmsupdate.jQuery object. You need to change cmsupdate.jQuery to window.jQuery. The methods you need to copy are doEncryptedAjax, pingExtract, startExtract, stepExtract, finalizeUpdate and also the functions empty and is_array (the latter two come from the awesome php.js library). Normally my Javascript is licensed under GPLv3 but I do give my permission to relicense it under "GPLv2 or any later version published by the Free Software Foundation" which is compatible with Joomla!.

And thus, with one swift change, you can remove all mooTools dependencies from Joomla! Update. You're welcome :)

avatar dgt41 dgt41 - change - 14 Apr 2015
The description was changed
avatar dgt41 dgt41 - change - 14 Apr 2015
The description was changed
avatar dgt41 dgt41 - change - 15 Apr 2015
The description was changed
avatar dgt41
dgt41 - comment - 15 Apr 2015

@nikosdion First and foremost mille grazie for your code! Once again!
Can you check that what I included in update.js is ok with you?
I owe you some beers for that ????

@wilsonge can you also check update.js in this PR? Do we need another comments block or this is fine?
In essence this is Nikolas’s code with few alterations to fit the html classes we use in the relative layout

avatar nikosdion
nikosdion - comment - 15 Apr 2015

Can you give me some time to review it until Monday evening? My laptop was stolen, I replaced it, but now I have to get everything properly set up.

avatar dgt41
dgt41 - comment - 15 Apr 2015

WOW that sucks! I hope you’ve got at least a backup of all the precious staff of your laptop. No rush here...

avatar nikosdion
nikosdion - comment - 19 Apr 2015

I can see that the total size of the update file being extracted (and, as a result, the percentage done) is always zero.

avatar dgt41
dgt41 - comment - 19 Apr 2015

@nikosdion Thanks Nick, I changed the script to reflect on values:
screen shot 2015-04-19 at 7 18 42
screen shot 2015-04-19 at 7 18 43

avatar nikosdion
nikosdion - comment - 19 Apr 2015

In file administrator/components/com_joomlaupdate/controller.php change line 46 from

$model = $this->getModel($vName);

to

$model = $this->getModel('default');

This should fix the fatal error.

avatar zero-24 zero-24 - change - 29 Apr 2015
Category JavaScript
avatar zero-24 zero-24 - change - 29 Apr 2015
Rel_Number 5386
Relation Type Related to
avatar zero-24 zero-24 - change - 29 Apr 2015
Category JavaScript External Library JavaScript
avatar dgt41 dgt41 - change - 5 May 2015
The description was changed
avatar wilsonge wilsonge - change - 29 May 2015
Milestone Added:
avatar dgt41 dgt41 - change - 30 May 2015
The description was changed
e03f38d 30 May 2015 avatar dgt41 init
avatar zero-24
zero-24 - comment - 30 May 2015

@test successfully. Thanks :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6769.

avatar zero-24 zero-24 - test_item - 30 May 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 6 Jun 2015

@losedk do you have few minutes spare to test this one?
Thanks!

avatar losedk
losedk - comment - 6 Jun 2015

@dgt41 Just tested. No errors on update, so I guess that's a successful test :)

avatar anibalsanchez
anibalsanchez - comment - 6 Jun 2015

@test on staging + 6769.diff. It has worked perfectly!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6769.

avatar anibalsanchez anibalsanchez - test_item - 6 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - alter_testresult - 6 Jun 2015 - losedk: Tested successfully
avatar zero-24 zero-24 - change - 6 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 6 Jun 2015

Great :smile: RTC!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6769.

avatar zero-24 zero-24 - change - 6 Jun 2015
Labels Added: ?
avatar mbabker
mbabker - comment - 11 Jul 2015

Merged to 3.5-dev via 577ed48

avatar zero-24 zero-24 - close - 11 Jul 2015
avatar mbabker mbabker - change - 11 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-11 14:18:48
Closed_By mbabker
avatar mbabker mbabker - close - 11 Jul 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment