[#6709] - More inline scripts through API
- Closed
- 17 Jun 2015
- Medium
- Build: staging
- Easy Test
- # 6709
- Diff
- dgt41:_inline_scripts2
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Remove inline script tags from body
Inline scripts should be loaded through API e.g. addScriptDeclaration()
Testing
Apply patch
Goto:
/administrator/index.php?option=com_banners&view=client&layout=edit
/administrator/index.php?option=com_banners&view=tracks
/administrator/index.php?option=com_config&view=component&component=com_content Make sure the first tab is the default one
/administrator/index.php?option=com_languages&view=language&layout=edit&lang_id=1
/administrator/index.php?option=com_media
try the usual form options, submit, cancel etc
B/C
NONE
Performance impact
This should not degrade performance!
Also using the API might enable us to get all the scripts to the end of the page and thus get a performance increase! (we’re NOT there yet!)
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | JavaScript |
| Category | JavaScript | ⇒ | Administration JavaScript |
tested, works ok !
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6709.
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6709.
| Labels |
Added:
?
|
||
I made an mistake on media field view, now it is corrected!
To test edit an article, goto images, select an image
everything should work fine!
I guess RTC has to be removed...
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
I have just tested the fixed bug. So we can move this back to RTC 
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6709.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-17 21:15:41 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@test
Works, no issues discovered after applying patch. Seems to be working correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6709.