[#6708] - Handle DB errors in articles archive module
- Closed
- 16 Jun 2015
- Medium
- Build: staging
- # 6708
- Diff
- alikon:patch-23
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | ⇒ | Modules SQL |
wilsonge
- | Milestone |
Added: |
||
Tested by changing columnname created to creeated
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6708.
Could you please provide some test data/scripts/files and some test instructions?
Try: https://github.com/alikon/joomla-cms/blob/patch-23/modules/mod_articles_archive/helper.php#L39
-->where('state = 2 AND checked_out = 0')
+->where('state_error = 2 AND checked_out_error = 0')
Tested by changing the columname created to created in the content table.
Resulted in a SQL error message in the message position in red.
Test result OK.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6708.
Object to this PR. Suggest to change the template to cope with no archived articles which will take care of the situation something went wrong in the database. Website visitor should not be confronted with infra problems. Just stating there are no archives should be enough.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6708.
| Labels |
Added:
?
|
||
Bakual
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-06-16 11:32:00 |
| Closed_By | ⇒ | Bakual |
| Labels |
Removed:
?
|
||
Could you please provide some test data/scripts/files and some test instructions?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6708.