Feeling Lucky
?
[#6706] - Inline scripts should use API
- Closed
- 25 May 2015
- Medium
- Build: staging
- # 6706
- Diff
- dgt41:_inline_script
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Remove inline script tags from body
Inline scripts should be loaded through API e.g. addScriptDeclaration()
Testing
Apply patch
Goto /administrator/index.php?option=com_installer
try to install something with all the possible options
B/C
NONE
Performance impact
This should not degrade performance!
Also using the API might enable us to get all the scripts to the end of the page and thus get a performance increase! (we’re NOT there yet!)
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration JavaScript |
davdebcom
- comment
- 10 Apr 2015
@test
Seems to be working (does not break anything). Nice code improvements!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6706.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 10 Apr 2015
RTC'ing 
Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6706.
| Labels |
Added:
?
|
||
phproberto
- comment
- 21 Apr 2015
Even being a small change I'm marking this PRs as v3.5.0 to avoid issues in minor releases
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-25 20:58:38 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@test installed an extension using the upload function, tmp folder, and URL. No errors installing the extension.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6706.