@810 "and you can't override it with you own css or less files."

That's not true. The hard-coded CSS is only used if template colours are switched on.

For override with your own css files, simply switch off template colours in templates setting.

The change in this PR here is not useful from my point of view, because it makes behavior with template colours on extremely different to the behavior with template colors off.

There is no option to turn "Off", you can only pick the color. but the setting are for:

• nav-list
• nav-bar
• dropdown-menu
• nav-pills
• btn-primary

Everything is just 1 setting.

@brianteeman I'm recommending we close this issue as its not a bug but infact is as designed.
@810 you can simply use a custom.css to override extremely easily. Many template generate styling @ runtime and protostar is not different.

custom.css is your friend.
Bear
On 4/8/2015 17:10, Jelle Kok wrote:

There is no option to turn "Off", you can only pick the color. but the
setting are for:

• nav-list
• nav-bar
• dropdown-menu
• nav-pills
• btn-primary

Everything is just 1 setting.

—
Reply to this email directly or view it on GitHub
#6705 (comment).

No virus found in this message.
Checked by AVG - www.avg.com http://www.avg.com
Version: 2015.0.5863 / Virus Database: 4328/9488 - Release Date: 04/08/15

@test works as aspected.

@test Don't know if this is gonna be closed, but the patch works as described.

@test works as expected.

Could we merge this one?

In my opinion: Make a copy of template Protostar, apply your changes, and leave Protostar as it is.
Or: #6705 (comment)

Additionally this PR is not B/C.

@bertmert if I have done this for myself, then its ok, But I'm a developer for a component. If users try our component, it will look ugly. We have used the default bootstrap styling. The issue is that the setting is overruling our less files.

I don't have to decide it ;-) This hard code shouldn't be there but it is in Protostar for a long time now. So I see B/C problems. That's all. I don't have no preferences.

Just BTW: It's possible to overrule these declarations in a custom CSS file even if this file is loaded before (by higher selector hierarchy).

Putting design opinions aside, the current inline CSS makes reading the menu items difficult. So regardless to what I believe about styling, the current method is bad UX. I have perfect vision and it takes longer to read based on the bad contrast. I'm completely in favor of the PR above.

If we really want this hard to read menu style for backwards compatibility reasons, why not have it as CSS within the template? Inline CSS for global classes like these doesn't make a lot of sense.

Setting to Needs Review so a CMS Maintainer can take a decision.

@810 I feel it's a stupid question but where is that navbar-inner thing even used in Protostar?
Or is that extension specific? If so, which extension can I install to see it in effect?

@Bakual
When Kyle created this template "Bootstrap" was new, and forgot to remove the hardcode on a test, I think.

Its not used in any default Joomla module.

So this are the test instructions:

1) Install kunena (enable forum menu item on main menu)
2) Set Crypsis as default kunena template
3) See frontend. That the menu looks ok.
4) Go to edit protostar template
5) Click on Save
6) See frontend again

You will see that the looks are bad.

Thanks, was able to reproduce this and it indeed looks crap with any color I tried.
The text is almost unreadable in all variants. So this indeed looks like a mistake to have by default.