What test did you expect to fail?

In the csv file of the tests it is looking for "custom html"

On 23 March 2015 at 15:29, Robert Deutz notifications@github.com wrote:

What test did you expect to fail?

—
Reply to this email directly or view it on GitHub
#6555 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Maybe replace "create" with "code".

In fact, we do not need No BOM anymore in 3.x as parse_ini does not need it.
See: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/language.php#L869

moved the BOM discussion to a new issue out of courtesy to this PR.

#6574

Aplpied the patch. The name of the Custom HTML modulke is correctly changed to "Custom" in the list of available moduels when adding a new module. But the Module Manager screen still shows " Module Manager: Module Custom HTML" as page heading and the title above the editor area still shows "Custom HTML".

Thanks for testing @erikvandoorne I missed that one - now fixed

Change in string missing in the ini file (should be I guess similar to the sys.ini)
in brianteeman@4225b1c#diff-f3d6a1d2248277bf7cd4e7f59db211c2R9

would this need creating update sql?

Not sure I understand which string is missing from the PR - you reference just the last update to the PR

I dont know about the update.sql @wilsonge @roland-d can you advise on the update.sql

@infograf768 Can you explain where the update SQL should be needed for? I don't see any database changes that are needed.

Simon it is deliberately not "content" as it is used for many thing that
are not HTML or content eg a JavaScript snippet
On 6 Jun 2015 15:00, "RolandD" notifications@github.com wrote:

@infograf768 https://github.com/infograf768 Can you explain where the
update SQL should be needed for? I don't see any database changes that are
needed.

—
Reply to this email directly or view it on GitHub
#6555 (comment).

I meant that this PR has not changed the .ini values as it did for the sys.ini ones IN BACKEND html module
In the sys.ini we now have:
MOD_CUSTOM="Custom"
MOD_CUSTOM_XML_DESCRIPTION="This module allows you to create your own Module using a WYSIWYG editor."
MOD_CUSTOM_LAYOUT_DEFAULT="Default"

in the .ini we still have:
MOD_CUSTOM="Custom HTML"
MOD_CUSTOM_FIELD_PREPARE_CONTENT_DESC="Optionally prepare the content with Joomla Content Plugins."
MOD_CUSTOM_FIELD_PREPARE_CONTENT_LABEL="Prepare Content"
MOD_CUSTOM_XML_DESCRIPTION="This module allows you to create your own HTML Module using a WYSIWYG editor."

@roland-d
Correct. Was just wondering without realy checking.

Thanks @infograf768 not sure what happened with the PR - the change was there in my local branch but not in the PR. It is now

merge conflicts in front-end ini

Merge conflicts resolved

I have tested this item successfully on 16ec1d9

At Test works

RTC

Thanks everybody. Merged into 3.5-dev with commit 72dd184