? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Mar 2015

This PR changes the name of the Custom HTML module to simply custom which better reflects its usage as it can be used for more than simple HTML.

Some languages (eg french) have not used the name Custom HTML for quite some time.

This change is a proposal from the en-GB working groups see joomla/user-interface-text#18

I have updated the language files AND the sample data files to reflect this change. I have not updated the csv files in the test suite as I am not 100% confident in doing that - perhaps @rdeutz or one of the other unit test team can update that

avatar brianteeman brianteeman - open - 23 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 23 Mar 2015
Category Language & Strings UI/UX
avatar brianteeman brianteeman - change - 23 Mar 2015
Easy No Yes
avatar brianteeman brianteeman - change - 23 Mar 2015
Title
change custom html to custom
change custom html to custom
avatar rdeutz
rdeutz - comment - 23 Mar 2015

What test did you expect to fail?

avatar brianteeman
brianteeman - comment - 23 Mar 2015

In the csv file of the tests it is looking for "custom html"

On 23 March 2015 at 15:29, Robert Deutz notifications@github.com wrote:

What test did you expect to fail?


Reply to this email directly or view it on GitHub
#6555 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar sovainfo
sovainfo - comment - 23 Mar 2015

Maybe replace "create" with "code".

avatar infograf768
infograf768 - comment - 24 Mar 2015

In fact, we do not need No BOM anymore in 3.x as parse_ini does not need it.
See: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/language.php#L869

avatar Hils
Hils - comment - 24 Mar 2015

moved the BOM discussion to a new issue out of courtesy to this PR.

avatar Hils
Hils - comment - 24 Mar 2015
avatar erikvandoorne
erikvandoorne - comment - 10 Apr 2015

Aplpied the patch. The name of the Custom HTML modulke is correctly changed to "Custom" in the list of available moduels when adding a new module. But the Module Manager screen still shows " Module Manager: Module Custom HTML" as page heading and the title above the editor area still shows "Custom HTML".


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6555.

avatar erikvandoorne erikvandoorne - test_item - 10 Apr 2015 - Tested unsuccessfully
avatar brianteeman brianteeman - change - 31 May 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 31 May 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 6 Jun 2015

Thanks for testing @erikvandoorne I missed that one - now fixed

avatar wilsonge wilsonge - change - 6 Jun 2015
Milestone Added:
avatar infograf768
infograf768 - comment - 6 Jun 2015

Change in string missing in the ini file (should be I guess similar to the sys.ini)
in brianteeman@4225b1c#diff-f3d6a1d2248277bf7cd4e7f59db211c2R9

would this need creating update sql?

avatar brianteeman
brianteeman - comment - 6 Jun 2015

Not sure I understand which string is missing from the PR - you reference just the last update to the PR

I dont know about the update.sql @wilsonge @roland-d can you advise on the update.sql

avatar roland-d
roland-d - comment - 6 Jun 2015

@infograf768 Can you explain where the update SQL should be needed for? I don't see any database changes that are needed.

avatar brianteeman
brianteeman - comment - 6 Jun 2015

Simon it is deliberately not "content" as it is used for many thing that
are not HTML or content eg a JavaScript snippet
On 6 Jun 2015 15:00, "RolandD" notifications@github.com wrote:

@infograf768 https://github.com/infograf768 Can you explain where the
update SQL should be needed for? I don't see any database changes that are
needed.


Reply to this email directly or view it on GitHub
#6555 (comment).

avatar infograf768
infograf768 - comment - 7 Jun 2015

I meant that this PR has not changed the .ini values as it did for the sys.ini ones IN BACKEND html module
In the sys.ini we now have:
MOD_CUSTOM="Custom"
MOD_CUSTOM_XML_DESCRIPTION="This module allows you to create your own Module using a WYSIWYG editor."
MOD_CUSTOM_LAYOUT_DEFAULT="Default"

in the .ini we still have:
MOD_CUSTOM="Custom HTML"
MOD_CUSTOM_FIELD_PREPARE_CONTENT_DESC="Optionally prepare the content with Joomla Content Plugins."
MOD_CUSTOM_FIELD_PREPARE_CONTENT_LABEL="Prepare Content"
MOD_CUSTOM_XML_DESCRIPTION="This module allows you to create your own HTML Module using a WYSIWYG editor."

avatar infograf768
infograf768 - comment - 7 Jun 2015

@roland-d
Correct. Was just wondering without realy checking.

avatar brianteeman
brianteeman - comment - 7 Jun 2015

Thanks @infograf768 not sure what happened with the PR - the change was there in my local branch but not in the PR. It is now

avatar infograf768
infograf768 - comment - 7 Jun 2015

merge conflicts in front-end ini

avatar brianteeman
brianteeman - comment - 21 Aug 2015

Merge conflicts resolved

avatar zero-24 zero-24 - alter_testresult - 23 Aug 2015 - erikvandoorne: Not tested
avatar ceus1984 ceus1984 - test_item - 24 Oct 2015 - Tested successfully
avatar ceus1984
ceus1984 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 16ec1d9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6555.

avatar DavidTrenkle DavidTrenkle - test_item - 24 Oct 2015 - Tested successfully
avatar DavidTrenkle
DavidTrenkle - comment - 24 Oct 2015

At Test works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6555.

avatar zero-24 zero-24 - change - 24 Oct 2015
Status Pending Ready to Commit
Labels
avatar zero-24
zero-24 - comment - 24 Oct 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6555.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar brianteeman brianteeman - reference | 72dd184 - 25 Oct 15
avatar roland-d
roland-d - comment - 25 Oct 2015

Thanks everybody. Merged into 3.5-dev with commit 72dd184

avatar roland-d roland-d - change - 25 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-25 11:32:13
Closed_By roland-d
avatar roland-d roland-d - close - 25 Oct 2015
avatar brianteeman brianteeman - head_ref_deleted - 25 Oct 2015
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment