User tests: Successful: Unsuccessful:
Attempting to install tarballed extensions that contain paths with more than 100 characters will result in paths being truncated. The original TAR format only supports paths up to 100 characters source.
I've put a test archive here. The archive contains the following path:
admin/plugins/vmpayment/amazon/library/OffAmazonPaymentsService/OffAmazonPaymentsService.config.inc.php
Test it by using Extensions
> Extension Manager
> upload the archive and click on Upload & Install
. You'll see a blank page (the installer script is meant to die so that the archive is extracted to your tmp
directory). Navigate to the tmp
directory and look for an install_<random_hash>
folder. Look at its contents - the OffAmazonPaymentsService.config.inc.php
filename will be truncated since it exceeds the 100 limit.
In what seems to be a PAX implementation of tar
, there's an 'L' flag that can be set so that the file name will reside in the contents block and the contents of the actual file are in the next block. This allows for longer paths to be stored. source 1 source 2
If you want to test for yourself, you can create a tar
archive using 7-Zip which produces this type of archives.
The PR addresses this issue and properly extracts the archive contents (perhaps there are other implementations of TAR long filenames, but I haven't found anything conclusive).
Rel_Number | ⇒ | 6133 | |
Relation Type | ⇒ | Pull Request for |
Labels |
Added:
?
|
Category | ⇒ | Installation |
Can you let me know how you tested? Perhaps provide the test archive you're using if it's not the one from above?
I downloaded the archive you provided
Applied patch
Used the installer to install the archive
White page
Oops - maybe the blank page is an issue with the test package and expected
Looking in the /tmp folder I can see that before the patch the filename was truncated and after the patch the filename was complete
And this part doesn't happen?
Navigate to the tmp directory and look for an install_ folder. Look at its contents - the OffAmazonPaymentsService.config.inc.php filename will be truncated since it exceeds the 100 limit.
Isn't the filename correctly named after the patch is applied? Assuming you're looking at the right folder :)
Our messages crossed.
Changing my result to successful
Thanks for taking the time to test :)
Works great. Thanks @OctavianC I have just send you a quick CS PR that changes /* ... */
to //...
If thats go in can you just ping me (@zero-24)? Than i will set it RTC.
Thanks
Status | Pending | ⇒ | Ready to Commit |
Thanks RTC. Travis fails not on this PR and only on one PHP Version.
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-10 13:55:14 |
Closed_By | ⇒ | Kubik-Rubik |
Thank you @OctavianC! Merged.
Labels |
Removed:
?
|
I can confirm the issue BUT the patch did not change the issue
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6554.