? Success
Pull Request for # 6133

User tests: Successful: Unsuccessful:

avatar OctavianC
OctavianC
23 Mar 2015

Issue

Attempting to install tarballed extensions that contain paths with more than 100 characters will result in paths being truncated. The original TAR format only supports paths up to 100 characters source.

How to test

I've put a test archive here. The archive contains the following path:

admin/plugins/vmpayment/amazon/library/OffAmazonPaymentsService/OffAmazonPaymentsService.config.inc.php

Test it by using Extensions > Extension Manager > upload the archive and click on Upload & Install. You'll see a blank page (the installer script is meant to die so that the archive is extracted to your tmp directory). Navigate to the tmp directory and look for an install_<random_hash> folder. Look at its contents - the OffAmazonPaymentsService.config.inc.php filename will be truncated since it exceeds the 100 limit.

Workaround

In what seems to be a PAX implementation of tar, there's an 'L' flag that can be set so that the file name will reside in the contents block and the contents of the actual file are in the next block. This allows for longer paths to be stored. source 1 source 2

If you want to test for yourself, you can create a tar archive using 7-Zip which produces this type of archives.

The PR addresses this issue and properly extracts the archive contents (perhaps there are other implementations of TAR long filenames, but I haven't found anything conclusive).

avatar OctavianC OctavianC - open - 23 Mar 2015
avatar zero-24 zero-24 - change - 23 Mar 2015
Rel_Number 6133
Relation Type Pull Request for
avatar joomla-cms-bot joomla-cms-bot - change - 23 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 27 Mar 2015
Category Installation
avatar brianteeman
brianteeman - comment - 17 Jun 2015

I can confirm the issue BUT the patch did not change the issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6554.

avatar brianteeman brianteeman - test_item - 17 Jun 2015 - Tested unsuccessfully
avatar OctavianC
OctavianC - comment - 17 Jun 2015

Can you let me know how you tested? Perhaps provide the test archive you're using if it's not the one from above?

avatar brianteeman
brianteeman - comment - 17 Jun 2015

I downloaded the archive you provided
Applied patch
Used the installer to install the archive
White page

avatar brianteeman
brianteeman - comment - 17 Jun 2015

Oops - maybe the blank page is an issue with the test package and expected

Looking in the /tmp folder I can see that before the patch the filename was truncated and after the patch the filename was complete

avatar OctavianC
OctavianC - comment - 17 Jun 2015

And this part doesn't happen?

Navigate to the tmp directory and look for an install_ folder. Look at its contents - the OffAmazonPaymentsService.config.inc.php filename will be truncated since it exceeds the 100 limit.

Isn't the filename correctly named after the patch is applied? Assuming you're looking at the right folder :)

avatar brianteeman
brianteeman - comment - 17 Jun 2015

Our messages crossed.

Changing my result to successful

avatar brianteeman brianteeman - alter_testresult - 17 Jun 2015 - brianteeman: Tested successfully
avatar OctavianC
OctavianC - comment - 17 Jun 2015

Thanks for taking the time to test :)

avatar zero-24 zero-24 - test_item - 17 Jun 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 17 Jun 2015

Works great. Thanks @OctavianC I have just send you a quick CS PR that changes /* ... */ to //... If thats go in can you just ping me (@zero-24)? Than i will set it RTC.

Thanks :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6554.

avatar OctavianC OctavianC - reference | 9434672 - 17 Jun 15
avatar OctavianC
OctavianC - comment - 17 Jun 2015

Done :) @zero-24

avatar zero-24 zero-24 - change - 18 Jun 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 18 Jun 2015

Thanks :+1: RTC. Travis fails not on this PR and only on one PHP Version.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6554.

avatar zero-24 zero-24 - change - 18 Jun 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 10 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - close - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - change - 10 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-10 13:55:14
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Jul 2015

Thank you @OctavianC! Merged.

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment