User tests: Successful: Unsuccessful:
This is the same fix as here: #3026, except that in the old pull request I've somehow screwed it up...
When I originally fixed this issue, the configuration didn't have Javascript validation. That is why I was able to run into this. Right now the config has a javascript validation and we can only run into the issue when we turn it off. But despite the fact that we can't run into the issue when js validation is on, it doesn't change the fact that the php code is wrong.
Testing instructions:
First we need to disable the javascript validation. Go to:
administrator\components\com_config\view\component\tmpl\default.php
comment out line 23,24 & 27. At the end your code should look like this:
Joomla.submitbutton = function(task)
{
// if (task === "config.cancel.component" || document.formvalidator.isValid(document.getElementById("component-form")))
// {
Joomla.submitform(task, document.getElementById("component-form"));
// }
};
After that test it with CMandrill:
First download CMandrill from:
https://compojoom.com/downloads/official-releases-stable/mandrill
then install it. Now go to components -> CMandrill options. Go to the permissions tab and try to change any permission. Save. The page will refresh without any error message and the permissions that you've applied shouldn't be saved.
Now apply the patch and try to save the config again. This time you'll see the error message.
Labels |
Added:
?
|
Category | ⇒ | Administration Components |
Title |
|
||||||
Easy | No | ⇒ | Yes |
@test OK - Patch works as advertised.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-16 15:00:48 |
Merged - thanks!
@test Succes. Patch works as described/expected.