? Success

User tests: Successful: Unsuccessful:

avatar compojoom
compojoom
15 Mar 2015

This is the same fix as here: #3026, except that in the old pull request I've somehow screwed it up...

When I originally fixed this issue, the configuration didn't have Javascript validation. That is why I was able to run into this. Right now the config has a javascript validation and we can only run into the issue when we turn it off. But despite the fact that we can't run into the issue when js validation is on, it doesn't change the fact that the php code is wrong.

Testing instructions:
First we need to disable the javascript validation. Go to:
administrator\components\com_config\view\component\tmpl\default.php
comment out line 23,24 & 27. At the end your code should look like this:

Joomla.submitbutton = function(task)
    {
//      if (task === "config.cancel.component" || document.formvalidator.isValid(document.getElementById("component-form")))
//      {
            Joomla.submitform(task, document.getElementById("component-form"));
//      }
    };

After that test it with CMandrill:
First download CMandrill from:
https://compojoom.com/downloads/official-releases-stable/mandrill

then install it. Now go to components -> CMandrill options. Go to the permissions tab and try to change any permission. Save. The page will refresh without any error message and the permissions that you've applied shouldn't be saved.

Now apply the patch and try to save the config again. This time you'll see the error message.

avatar compojoom compojoom - open - 15 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 Mar 2015
Category Administration Components
avatar zero-24 zero-24 - change - 15 Mar 2015
The description was changed
Title
Config doesn't output error message, when we have a required field (PHP ...
Config doesn't output error message, when we have a required field (PHP validation, not JS!)
Easy No Yes
avatar bertmert
bertmert - comment - 15 Mar 2015

@test Succes. Patch works as described/expected.

avatar zero-24 zero-24 - alter_testresult - 15 Mar 2015 - bertmert: Tested successfully
avatar matrikular
matrikular - comment - 15 Mar 2015

@test OK - Patch works as advertised.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6439.
avatar matrikular matrikular - test_item - 15 Mar 2015 - Tested successfully
avatar wilsonge wilsonge - change - 16 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-16 15:00:48
avatar wilsonge wilsonge - close - 16 Mar 2015
avatar wilsonge wilsonge - reference | - 16 Mar 15
avatar wilsonge wilsonge - merge - 16 Mar 2015
avatar wilsonge wilsonge - close - 16 Mar 2015
avatar wilsonge
wilsonge - comment - 16 Mar 2015

Merged - thanks!

Add a Comment

Login with GitHub to post a comment