? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Mar 2015

This is a redo of #4645

Scope

Use bootstrap instead of the mootools modal!

Testing

Apply patch
go to /administrator/index.php?option=com_templates&view=templates
click on the thumbs

Preview

screen shot 2015-03-12 at 9 25 35

1b09904 12 Mar 2015 avatar dgt41 CS
7eed296 12 Mar 2015 avatar dgt41 CS
36c66a7 12 Mar 2015 avatar dgt41 more
avatar dgt41 dgt41 - open - 12 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 12 Mar 2015

@dgt41 know funny thing?
you do not need to call JHtml::_('bootstrap.modal'); while you have button with data-toggle="modal" :smile:

Bootstrap Modal see Usage: Via data attributes

avatar dgt41
dgt41 - comment - 12 Mar 2015

I guess I was carried away by the line above JHtml::_('bootstrap.tooltip');

avatar n9iels
n9iels - comment - 12 Mar 2015

The css width of 100% ensures that the image gets bigger than the original file size. Maybe you can use max-with:100%; instead?

avatar dgt41
dgt41 - comment - 12 Mar 2015

Thanks @n9iels, I was wondering for this. It would be even better if we had just a class there

avatar n9iels
n9iels - comment - 12 Mar 2015

A class for this doesn't exist so far I know.
But thanks for removing another mootools object :-)

@test works fine for me


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6408.
avatar n9iels n9iels - test_item - 12 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - change - 12 Mar 2015
Easy No Yes
avatar zero-24 zero-24 - change - 12 Mar 2015
Category JavaScript
avatar Erftralle
Erftralle - comment - 13 Mar 2015

@test looks good to me, thanks.

avatar adhocgraFX adhocgraFX - test_item - 14 Mar 2015 - Tested successfully
avatar zurborg zurborg - test_item - 14 Mar 2015 - Tested successfully
avatar degobbis degobbis - test_item - 14 Mar 2015 - Tested successfully
avatar matrikular matrikular - test_item - 14 Mar 2015 - Tested successfully
avatar web-mex web-mex - test_item - 14 Mar 2015 - Tested successfully
avatar MyDadisDead
MyDadisDead - comment - 14 Mar 2015

Very nice - test works fine

avatar web-mex
web-mex - comment - 14 Mar 2015

Hi, on resize the Browserwindow the Modalwindow will hide when the window get smaller as 500px.
I the old version the Window will reachable with scrollbar.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6408.
avatar web-mex
web-mex - comment - 14 Mar 2015

Hi, on resize the Browserwindow the Modalwindow will hide when the window get smaller as 500px.
I the old version the Window will reachable with scrollbar.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6408.
avatar dgt41
dgt41 - comment - 14 Mar 2015

@web-mex Thanks, should be fixed now!

avatar roland-d roland-d - change - 14 Mar 2015
Status Pending Ready to Commit
avatar designbengel designbengel - test_item - 14 Mar 2015 - Tested successfully
avatar dgt41
dgt41 - comment - 16 Mar 2015

@n9iels @Erftralle @MyDadisDead @web-mex Can I ask for a re-test here?
Try to open the modal and then resize the browser to mobile width. The modal should be still visible and adapt to the new size.

avatar MyDadisDead
MyDadisDead - comment - 16 Mar 2015

Hi
Reverted the patch,logged out to kill session, logged in and applied the new patch. Modal worked fine and is responsive. Great stuff!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6408.
avatar MyDadisDead MyDadisDead - test_item - 16 Mar 2015 - Tested successfully
avatar n9iels
n9iels - comment - 16 Mar 2015

@test works fine for me, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6408.
avatar dgt41
dgt41 - comment - 16 Mar 2015

@MyDadisDead @n9iels Can I be a pain in the a$$ and ask you to also test #4563 ?
Shouldn’t take much time, tho

avatar n9iels
n9iels - comment - 16 Mar 2015

No problem :+1:

avatar Erftralle
Erftralle - comment - 16 Mar 2015

@test: Patch is still working, thanks.
Noticed a little change to my previous test. Headline and image in the modal window are now left aligned instead of centered (like in your preview in the test instructions above). Liked it more when it was centered ;-) .

avatar dgt41
dgt41 - comment - 24 Mar 2015

@roland-d can you RTC this?

avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 2 May 2015
avatar roland-d roland-d - change - 2 May 2015
Milestone Removed:
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-02 16:40:25
Closed_By roland-d
avatar roland-d roland-d - close - 2 May 2015
avatar roland-d roland-d - close - 2 May 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment