User tests: Successful: Unsuccessful:
This is a redo of #4645
Use bootstrap instead of the mootools modal!
Apply patch
go to /administrator/index.php?option=com_templates&view=templates
click on the thumbs
Labels |
Added:
?
|
I guess I was carried away by the line above JHtml::_('bootstrap.tooltip');
The css width of 100% ensures that the image gets bigger than the original file size. Maybe you can use max-with:100%;
instead?
A class for this doesn't exist so far I know.
But thanks for removing another mootools object :-)
@test works fine for me
Easy | No | ⇒ | Yes |
Category | ⇒ | JavaScript |
Very nice - test works fine
Hi, on resize the Browserwindow the Modalwindow will hide when the window get smaller as 500px.
I the old version the Window will reachable with scrollbar.
Hi, on resize the Browserwindow the Modalwindow will hide when the window get smaller as 500px.
I the old version the Window will reachable with scrollbar.
Status | Pending | ⇒ | Ready to Commit |
@n9iels @Erftralle @MyDadisDead @web-mex Can I ask for a re-test here?
Try to open the modal and then resize the browser to mobile width. The modal should be still visible and adapt to the new size.
Hi
Reverted the patch,logged out to kill session, logged in and applied the new patch. Modal worked fine and is responsive. Great stuff!
@test works fine for me, thanks!
@MyDadisDead @n9iels Can I be a pain in the a$$ and ask you to also test #4563 ?
Shouldn’t take much time, tho
No problem
Labels |
Added:
?
|
Milestone |
Removed: |
||
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-02 16:40:25 |
Closed_By | ⇒ | roland-d |
Labels |
Removed:
?
|
@dgt41 know funny thing?
you do not need to call
JHtml::_('bootstrap.modal');
while you have button withdata-toggle="modal"
Bootstrap Modal see Usage: Via data attributes