[#6407] - Toolbar buttons fall outside view-poort
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6407
- Diff
- n9iels:toolbar-buttons
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The bug
On some phones, the end of the toolbar buttons fall of the screen. (Screenshots are from a nexus 5).
This problem occurs on LTR and RTL css.
How to test this patch
You can test this patch on a mobile phone, but it also can be test by using the developer tool of Google Chrome. Press F12, and click on the mobile icon next to the search icon. Select as device: Nexus 5
- Go to a page with Toolbar, this can be every view. Langue manager for example
- Confirm the bug on Nexus 5, also confirm the buttons are not 100% page width on iPhone 5.
- Apply the patch
- Confirm the buttons are now shown correctly
- Change device to iPhone 5 and confirm buttons are know shown the same as nexus 5
- Switch to a RTL language (Persion for example)
- Test the patch again
Note
When compiling the less files, some j-sidebar css compiled too. I didn't make changes to that css... I have no idea if that can cause problems.
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Templates (admin) UI/UX |
Thanks! I have changed it :-)
I also noticed a little bug on iPhone display size, the buttons were not 100% page width. I solved that one too and changed my test instructions
On iPhone the problem is that the buttons are not 100% page width. This patch makes the layout for the toolbar the same for al mobile devices. So if the buttons are shown correctly it is perfect 
designbengel
- 
Thanks for testing!
vdespa
- | Status | Pending | ⇒ | Ready to Commit |
degobbis
- 
web-mex
- 
tested - ok
RoterNagel
- 
Setting RTc - thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6407.
| Labels |
Added:
?
|
||
Tried it on my Samsung Galaxy 3 and could not replicate the error. Buttons OK
Patch works fine!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6407.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 07:35:57 |
Merged. Thanks!
| Labels |
Removed:
?
|
||
@test: successful
Issue confirmed and resolved with your patch :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6407.