? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
5 Mar 2015

Speed up the rule field, by disabling the Chosen for this field.

test
Open global configuration, and make sure that the permission fields do not use Chosen styling.
Also pay attention how fast "Global configuration" now :horse_racing: (if you have Intel i7 or Xeon processor, just ignore it :smile: )

It can have a huge performance boost, if site have a lot User Groups.
Even on test installation, on my PC, I got around -200ms for page rendering:

before patch:
screen 2015-03-05 11 17 46 1013x385

after patch:
screen 2015-03-05 11 18 28 1013x385

avatar Fedik Fedik - open - 5 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 5 Mar 2015

@test Verry good catch! My speed tests (Timeline in Google Chrome developer toools) give me a speed of 2.11 seconds without your patch. When I apply your patch the speeds is below 2 secondes, mostly 1.83 seconds.

One little note, please correct these and travis should be happy to :wink:

FILE: ...e/travis/build/joomla/joomla-cms/libraries/joomla/form/fields/rules.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 269 | WARNING | Line exceeds 150 characters; contains 152 characters
--------------------------------------------------------------------------------


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6317.
avatar n9iels n9iels - test_item - 5 Mar 2015 - Tested successfully
avatar Fedik
Fedik - comment - 5 Mar 2015

travis is most complicated part here :smile:

4e81548 5 Mar 2015 avatar Fedik c.s.
avatar Fedik
Fedik - comment - 5 Mar 2015

and question, related to the rule field,
what people think about make description always visible? ... instead of use tooltip

from:
screen 2015-03-05 13 09 11 615x321

to something like:
screen 2015-03-05 13 16 30 615x321

So user immediately see what rule for what....

avatar n9iels
n9iels - comment - 5 Mar 2015

Please make a new issue for that, so we can discuss it there.

Tanks for changing!
One more tester needed for this PR! :smile:

avatar Fedik
Fedik - comment - 5 Mar 2015

just asked, I not think that it is very important issue :wink:

avatar n9iels
n9iels - comment - 5 Mar 2015

I prefer tooltips. The are more clear for layout in my opinion. If you make the description directly visible it is to much information

avatar phproberto
phproberto - comment - 5 Mar 2015

Works great here :+1:

It saves from 1,2 -1,3 secs to 0,9 - 1,1 secs here

avatar zero-24 zero-24 - change - 5 Mar 2015
Status Pending Ready to Commit
avatar zero-24 zero-24 - alter_testresult - 6 Mar 2015 - phproberto: Tested successfully
avatar zero-24 zero-24 - change - 6 Mar 2015
Category JavaScript
avatar zero-24
zero-24 - comment - 6 Mar 2015

RTC based on testing. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6317.
avatar brianteeman brianteeman - change - 7 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 10 Mar 2015
avatar phproberto phproberto - change - 10 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-10 15:48:10
avatar phproberto phproberto - close - 10 Mar 2015
avatar phproberto phproberto - close - 10 Mar 2015
avatar phproberto
phproberto - comment - 10 Mar 2015

Merged. Thanks!

avatar Fedik Fedik - head_ref_deleted - 10 Mar 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment