[#6316] - Let the com_installer manager helper follow our codestyle
- Closed
- 5 Mar 2015
- Medium
- Build: staging
- # 6316
- Diff
- zero-24:patch-15
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR let the com_installer manager helper follow our codestyle.
I don't think here is testing required. I hope this can be merged on Review by PLT / Maintainer 
Else let me know.
joomla-cms-bot
- | Labels |
Added:
?
|
||
Just saw that you added a comma in the last part of the arrays (and also in your PR towards mine).
Are you sure this is correct?
Yes
The comma after the last array element is optional and can be omitted. This is usually done for single-line arrays, i.e. array(1, 2) is preferred over array(1, 2, ). For multi-line arrays on the other hand the trailing comma is commonly used, as it allows easier addition of new elements at the end.
http://php.net/manual/en/language.types.array.php
and
When splitting array definitions onto several lines, the last value may also have a trailing comma. This is valid PHP syntax and helps to keep code diffs minimal.
http://joomla.github.io/coding-standards/?coding-standards/chapters/php.md
Great!
brianteeman
- | Category | ⇒ | Code style |
wilsonge
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-05 11:30:42 |
| Milestone |
Added: |
||
Just saw that you added a comma in the last part of the arrays (and also in your PR towards mine).
Are you sure this is correct?