@test works for postgresql, mysql and mssql! Thanks @alikon!

This is one of those times where we should make the field not null actually I think

@wilsonge we need to review our data model constraints from the start
can you have a look at #6104

Déjà vu at #6355. What´s the decision here?

@alikon I've taken a closer look at this one and I would suggest the following set of changes instead (you would have to update the PR with these):
http://pastebin.com/6BCRMq75

The reason for the changes are:
1. In the current PR the review_time will always be set to the current date (even if the user selects a different date). It looks like currently with Notes we should allow for it to be empty (set to the Null Date for the Database)...here's the tooltip for the field: "Review Date is a manually entered date you can use as fits in your workflow. Examples would be to put in a date when you want to review a user or the last date you reviewed the user."
2. Even after making adjustments for the date in the JTable class, the User Notes List View doesn't correctly support the Postgres Null Date value (for the MySQL Null Date of 0000-00-00 00:00:00 it will just display a dash "-", for the Postgres Null Date it will display the actual 1970-01-01 00:00:00 date). I've added an additional change to the User Notes List view that changes that behavior and compares the stored Review Time against the current database driver's Null Date value instead so the output is consistent (at least across MySQL and Postgres).

I don't have any issues with the modified_user_id value being set the way it is so that part should be fine.

I've successfully tested things on my end with those modifications in place...hopefully if we can get the PR updated we can get some more people to officially test it as well.

Confirmed issue.
Confirmed PR resolves the issue

Multiple tests setting RTC

This breaks the review date functionality by always setting it to the last date the note was edited whereas you should be able to set it to any date or have the date as null. The last modified user change is correct but you need to fix the review time stuff before this can be merged

@alikon are you able to com up with a different solution based on @wilsonge comments

fixed the review_time functionality able to set it to any date (null included)
@brianteeman not so sure it is compliant with @wilsonge
cause i'm not changing null constraints

Thanks I will test later today

Retested after the changes and I can successfully create a note and set the review date as expected

Nah I'm happy with this. I mean ideally the modified user and date wouldn't be set on note creation - but as we are already doing the modified date i'm happy to standardize on that

Does this has issues with PHP 5.6?

Why are you experiencing any?

... not me, but I can swear I saw Travis complaining with PHP 5.6... strange... everything seems OK now...

ehmm... this seems to be the only PR still having a 3.4.2 milestone...

@waader are you able to retest the last changes here? so we can RTC it for 3.4.2? Thanks

Wrong button

@retest works!

RTC Thanks for testing and coding

Merged