[#6266] - Correct lookup paths in JPluginHelper::getLayoutPath()
- Closed
- 7 Mar 2015
- Medium
- Build: staging
- # 6266
- Diff
- mbabker:PluginLayoutPathFix
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When using JPluginHelper::getLayoutPath() in a plugin executing from the admin application, the lookup paths for the base plugin path are incorrect as the JPATH_BASE path constant is used to build the base path. This constant differs between the site and admin applications.
This PR adjusts the lookup paths to use the JPATH_PLUGINS path constant instead.
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries Plugins |
You'd really need a plugin that's using this feature to properly test it. I don't know of any which use it in the backend to be honest other than one I'm currently working on where I found the issue (I'd need to strip it down and sanitize it to share it).
Code looks absolutely correct. Right now, I only see one plugin use that code in Joomla core. It is "Content - Page Navigation". I tested that plugin and It is working as expected.
So @test success from me.
PS: I think with simple PR like this, someone can simply review code and merge it.
| Status | Pending | ⇒ | Ready to Commit |
Moving RTC Thanks for testing and coding!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6266.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-07 02:13:38 |
| Labels |
Removed:
?
|
||
I tested this patch by opening and saving some random plugin on the back-end. Is that a good way to test this patch?
Code looks also good to me
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6266.