nice

@zero-24 Did I do it right?

@losedk i have just comment on CS. That is why Travis fail here:

FILE: ...la/joomla-cms/administrator/components/com_users/helpers/html/users.php
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  58 | ERROR | Concat operator must be preceeded by one space
  58 | ERROR | Concat operator must be followed by one space
 112 | ERROR | Concat operator must be preceeded by one space
 112 | ERROR | Concat operator must be followed by one space
------------------------------------------------------------------------------

hehe you are quite fast

Did I do it right?

Looks good to me. Will test now.

Works great! Thanks @losedk

@dgt41 have you tested it?

@test OK
May I suggest tthis little change:

<div class="btn-group" data-toggle="buttons-radio">

instead of the simple <div> at the beginning of this block, will render like this:

Obviously without the data-toggle="buttons-radio"

@dgt41 Done. Had to add a div to the title as well, so it breaks correctly

I am afraid my suggestion breaks the mobile view.
Sorry about that, I should have checked that before suggesting it!
Maybe just icons (no text) and their own column is a better (?) way for this?
This will render to something more familiar e.g. like in articles:

@dgt41 I have added hidden-phone to the text elements

Nice work around!

@test success

Based purely on the screenshot there appears to be a double line between
the first two icons

On 2 March 2015 at 21:36, Dimitris Grammatiko notifications@github.com
wrote:

@test https://github.com/test success
[image: screen shot 2015-03-02 at 11 35 56]
https://cloud.githubusercontent.com/assets/3889375/6451111/f3177f80-c134-11e4-801b-0b47867d96eb.png

—
Reply to this email directly or view it on GitHub
#6264 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@brianteeman Yeah see it. It's because of the modal

<div id="userModal_471" tabindex="-1" class="modal hide fade">

I'm not quite sure how to fix that. @dgt41 any ideas?

Propper solution:
views/users/tmpl/default.php

                            <div class="btn-group">
                                <?php echo JHtml::_('users.filterNotes', $item->note_count, $item->id); ?>
                                <?php echo JHtml::_('users.notes', $item->note_count, $item->id); ?>
                                <?php echo JHtml::_('users.addNote', $item->id); ?>
                                <?php if ($item->requireReset == '1') : ?>
                                <span class="label label-warning"><?php echo JText::_('COM_USERS_PASSWORD_RESET_REQUIRED'); ?></span>
                                <?php endif; ?>
                            </div>
                            <?php echo JHtml::_('users.notesModal', $item->note_count, $item->id); ?>

administrator/components/com_users/helpers/html/users.php
Replace function notes with:

    /**
     * Displays a note icon.
     *
     * @param   integer  $count   The number of notes for the user
     * @param   integer  $userId  The user ID
     *
     * @return  string  A link to a modal window with the user notes
     *
     * @since   2.5
     */
    public static function notes($count, $userId)
    {
        if (empty($count))
        {
            return '';
        }

        $title = JText::plural('COM_USERS_N_USER_NOTES', $count);

        return '<a href="#userModal_' . (int) $userId . '" id="modal-' . (int) $userId . '" data-toggle="modal" class="hasTooltip btn btn-mini" title="' . $title . '">'
            . '<i class="icon-drawer-2"></i><span class="hidden-phone">' . $title . '</span></a>';
    }

    /**
     * Renders the modal html.
     *
     * @param   integer  $count   The number of notes for the user
     * @param   integer  $userId  The user ID
     *
     * @return  null
     *
     * @since   3.4.1
     */
    public static function notesModal($count, $userId)
    {
        if (empty($count))
        {
            return '';
        }

        $title = JText::plural('COM_USERS_N_USER_NOTES', $count);

        echo JHtmlBootstrap::renderModal(
            'userModal_' . (int) $userId, array(
                'url' => JRoute::_('index.php?option=com_users&view=notes&tmpl=component&layout=modal&u_id=' . (int) $userId),
                'title' => $title,
                'width' => '800px',
                'height' => '500px')
        );

        return null;
    }

@dgt41 Thanks a lot! :)

@test success

@zero-24 Could you test again? :)

@test still successful. good work @losedk and @dgt41! -> RTC

Just added a small tweak. Moved the below mentioned outside the btn-group

<?php if ($item->requireReset == '1') : ?>
<span class="label label-warning"><?php echo JText::_('COM_USERS_PASSWORD_RESET_REQUIRED'); ?></span>
<?php endif; ?> 

@dgt41 Done

I don't why this fails?

There was a bad update to one of the PEAR service provider packages in the last few days. We changed our code to not rely on it but branches without that change will fail until the provider fixes the issue.

@mbabker thanks for the clarification

All green again :)

@zero-24 should this be tested again? Or is it still RTC?

just tested and it is still RTC here thanks!

Merged. Thanks!