[#5879] - Updated deleted files listing for current staging
- Closed
- 24 Jan 2015
- Medium
- Build: staging
- # 5879
- Diff
- mbabker:deletedFilesList
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR updates the file listing for files to delete on update based on the current comparison between the 3.3.6 release tag and current staging branch.
This list can be produced at anytime by executing git diff tags/3.3.6 staging --name-status from a command line interface. All lines with a D as the first character are deleted files. For convenience, the output of this command is available at https://gist.github.com/mbabker/b65533dc1ef4b5e70e0a. This update excludes the weblinks extensions and index.html files (except for ones where the folder itself has been removed).
jissues-bot
- | Labels |
Added:
?
|
||
this should be done in each PR as people remove files. And currently isn't part of the workflow for a release. Although having said that might be an idea for that to happen
Generally it should done with each PR and at most whomever is building the release should only need to validate the script against the listing our build script generates. Really the only PRs that didn't include this were the CodeMirror updates. The major changes in terms of deleted files since 3.3.6 come from shifting around libraries with Composer and the updated CodeMirror version (which restructured how media is stored), as well as the weblinks and index.html file removals (which we elected to not put into the delete script).
As for deleted file listings themselves, the build script only generates these listings for maintenance releases within a minor series. Since we don't generate patch packages for, using as an example, 3.1.5 to 3.2.0 or 3.3.6 to 3.4.0 then this listing will never be created for minor releases.
zero-24
- | Category | ⇒ | Updating |
Thanks, Simple change. Merging.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-24 06:35:55 |
@mbabker do we need a PR for this? Shouldnt it be part of the workflow process for whoever makes the final release.
A PR for this now might need redoing multiple times before the actual release
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5879.