[#5880] - Fix CS issues in the build script
- Closed
- 25 Jan 2015
- Medium
- Build: staging
- Easy Test
- # 5880
- Diff
- zero-24:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR fix CS issues in the build script
jissues-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Code style Repository |
@zero-24 Can you please remove the last comma in the array? Thanks!
@Kubik-Rubik why? see here for the array example: http://joomla.github.io/coding-standards/?coding-standards/chapters/php.md
Assignments (the => operator) in arrays may be aligned with tabs. When splitting array definitions onto several lines, the last value may also have a trailing comma. This is valid PHP syntax and helps to keep code diffs minimal.
Ugly... ;-) Personally I would not use the commay in the last assignment but of course it is not an error:
Having a trailing comma after the last defined array entry, while unusual, is a valid syntax. (http://php.net/manual/en/function.array.php)
Since it is a no-brainer (just syntax changes) I will merge it PR. Thanks @zero-24!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-25 01:46:07 |
| Milestone |
Added: |
||
Thanks @Kubik-Rubik
@zero-24 Can you please remove the last comma in the array? Thanks!