? Success

User tests: Successful: Unsuccessful:

avatar sovainfo
sovainfo
23 Jan 2015

The introduction of fof in core didn't cater for old installations of the library. The scripts in the top level folder conclict with the proper working of core extensions based on fof.

avatar sovainfo sovainfo - open - 23 Jan 2015
avatar jissues-bot jissues-bot - change - 23 Jan 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 23 Jan 2015

I think we considered this in the past. But because often people did have such an old version of akeeba products installed things still got broken on their site because the FOF files no longer existed. I dunno whether @nikosdion can remember better than me.

avatar zero-24
zero-24 - comment - 23 Jan 2015

@wilsonge This: #2519 Is the PR by @nikosdion that you mean.

avatar zero-24 zero-24 - change - 23 Jan 2015
Category External Library Updating
avatar nikosdion
nikosdion - comment - 23 Jan 2015

This PR is correct. What @sovainfo means is this scenario:

You have an old Joomla! 1.6/1.7/2.5/3.0/3.1 site where FOF 1.x is installed. When you upgrade to Joomla! 3.2 or later the old FOF 1.x files exist in the libraries/fof folder along with the FOF 2.4 files. Due to the legacy mode in the FOF autoloader the FOF 1.x classes take precedence over FOF 2.4 causing the FOF-based components to crash.

This PR is absolutely correct and fairly trivial. @wilsonge please merge it. This is a serious problem for people upgrading from very old versions of Joomla! using very old versions of FOF-based components and the solution here is very simple and absolutely correct.

avatar wilsonge wilsonge - reference | - 23 Jan 15
avatar wilsonge wilsonge - merge - 23 Jan 2015
avatar wilsonge wilsonge - close - 23 Jan 2015
avatar wilsonge wilsonge - close - 23 Jan 2015
avatar wilsonge wilsonge - change - 23 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-23 13:16:24
avatar wilsonge
wilsonge - comment - 23 Jan 2015

I remember the scenario. I just thought that people with those old akeeba products had sites break as FOF no longer existed.

Doesn't matter anyhow. You're the boss in this regard!! merged

avatar nikosdion
nikosdion - comment - 23 Jan 2015

:+1:

avatar sovainfo sovainfo - head_ref_deleted - 23 Jan 2015
avatar sovainfo
sovainfo - comment - 23 Jan 2015

Thank you both!

Add a Comment

Login with GitHub to post a comment