User tests: Successful: Unsuccessful:
See #5864
Edit or create a language override through Language Manager.
Enter in the "Language Constant" field one of the reserved words:
YES, NO, NULL, FALSE or TRUE for example.
Save.
You will get a Fatal error:
Fatal error: Maximum function nesting level of '100' reached, aborting! in /Applications/MAMP/htdocs/trunkgitnew/libraries/joomla/language/language.php on line 1160
Delete the overrride ini file which was created and patch:
Labels |
Added:
?
|
In another place I believe we agreed that can't should be written in full as cannot.
We agreed the opposite ;)
On 23 January 2015 at 09:45, Hils notifications@github.com wrote:
In another place I believe we agreed that can't should be written in full
as cannot.—
Reply to this email directly or view it on GitHub
#5877 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Corrected.
OOps Hils I am not sure we did ever make a decision on that word - moving
to the en-GB issue list to discuss that
On 23 January 2015 at 09:57, Brian Teeman brian@teeman.net wrote:
We agreed the opposite ;)
On 23 January 2015 at 09:45, Hils notifications@github.com wrote:
In another place I believe we agreed that can't should be written in full
as cannot.—
Reply to this email directly or view it on GitHub
#5877 (comment).Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
My mistake the change to standardise on can't is in the big PR that isnt
applied yet
On 23 January 2015 at 10:05, Brian Teeman brian@teeman.net wrote:
OOps Hils I am not sure we did ever make a decision on that word - moving
to the en-GB issue list to discuss thatOn 23 January 2015 at 09:57, Brian Teeman brian@teeman.net wrote:
We agreed the opposite ;)
On 23 January 2015 at 09:45, Hils notifications@github.com wrote:
In another place I believe we agreed that can't should be written in
full as cannot.—
Reply to this email directly or view it on GitHub
#5877 (comment).Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Honestly, between cannot and can't, this is really fishing for useless details.
Please rather confirm if the PR is working for you or not.
With the language string as Should then no I can not confirm as it is not
the correct message
On 23 January 2015 at 10:09, infograf768 notifications@github.com wrote:
Honestly, between cannot and can't, this is really fishing for useless
details.
Please rather confirm if the PR is working for you or not.—
Reply to this email directly or view it on GitHub
#5877 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
The check works for me.
Manually pasted patch into com_languages/models/overwrite.php
Try to save keys named YES, NO, TRUE, FALSE, ON, OFF, NULL, NONE
(Maybe they should mentioned in this order in the message)
Result: Save process is canceled, Error Message was presented.
Category | ⇒ | Language & Strings |
Easy | No | ⇒ | Yes |
@test OK
Thank you for correcting the string
On 23 Jan 2015 15:07, "Anibal Sanchez" notifications@github.com wrote:
@test https://github.com/test OK
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/5877
http://issues.joomla.org/tracker/joomla-cms/5877.—
Reply to this email directly or view it on GitHub
#5877 (comment).
Status | Pending | ⇒ | Ready to Commit |
Moving to RTC Thanks!
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-24 06:32:56 |
It is better for the language string to change the word should to can't
+COM_LANGUAGES_OVERRIDE_ERROR_RESERVED_WORDS="YES, NO, NULL, FALSE, ON, OFF, NONE, TRUE are reserved words and should not be used as language constants."
should not be used = implies it is bad practice to do so but there is no problem if you do. Whereas in reality you can't use them.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5877.