? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Jan 2015

See #5864
Edit or create a language override through Language Manager.
Enter in the "Language Constant" field one of the reserved words:
YES, NO, NULL, FALSE or TRUE for example.
Save.
You will get a Fatal error:

Fatal error: Maximum function nesting level of '100' reached, aborting! in /Applications/MAMP/htdocs/trunkgitnew/libraries/joomla/language/language.php on line 1160

Delete the overrride ini file which was created and patch:

You will get:
screen shot 2015-01-23 at 09 48 42

avatar infograf768 infograf768 - open - 23 Jan 2015
avatar jissues-bot jissues-bot - change - 23 Jan 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 23 Jan 2015

It is better for the language string to change the word should to can't

+COM_LANGUAGES_OVERRIDE_ERROR_RESERVED_WORDS="YES, NO, NULL, FALSE, ON, OFF, NONE, TRUE are reserved words and should not be used as language constants."

should not be used = implies it is bad practice to do so but there is no problem if you do. Whereas in reality you can't use them.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5877.
avatar Hils
Hils - comment - 23 Jan 2015

In another place I believe we agreed that can't should be written in full as cannot.

avatar brianteeman
brianteeman - comment - 23 Jan 2015

We agreed the opposite ;)

On 23 January 2015 at 09:45, Hils notifications@github.com wrote:

In another place I believe we agreed that can't should be written in full
as cannot.


Reply to this email directly or view it on GitHub
#5877 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768 infograf768 - change - 23 Jan 2015
The description was changed
avatar infograf768
infograf768 - comment - 23 Jan 2015

Corrected.

avatar brianteeman
brianteeman - comment - 23 Jan 2015

OOps Hils I am not sure we did ever make a decision on that word - moving
to the en-GB issue list to discuss that

On 23 January 2015 at 09:57, Brian Teeman brian@teeman.net wrote:

We agreed the opposite ;)

On 23 January 2015 at 09:45, Hils notifications@github.com wrote:

In another place I believe we agreed that can't should be written in full
as cannot.


Reply to this email directly or view it on GitHub
#5877 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 23 Jan 2015

My mistake the change to standardise on can't is in the big PR that isnt
applied yet

On 23 January 2015 at 10:05, Brian Teeman brian@teeman.net wrote:

OOps Hils I am not sure we did ever make a decision on that word - moving
to the en-GB issue list to discuss that

On 23 January 2015 at 09:57, Brian Teeman brian@teeman.net wrote:

We agreed the opposite ;)

On 23 January 2015 at 09:45, Hils notifications@github.com wrote:

In another place I believe we agreed that can't should be written in
full as cannot.


Reply to this email directly or view it on GitHub
#5877 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 23 Jan 2015

Honestly, between cannot and can't, this is really fishing for useless details.
Please rather confirm if the PR is working for you or not.

avatar brianteeman
brianteeman - comment - 23 Jan 2015

With the language string as Should then no I can not confirm as it is not
the correct message

On 23 January 2015 at 10:09, infograf768 notifications@github.com wrote:

Honestly, between cannot and can't, this is really fishing for useless
details.
Please rather confirm if the PR is working for you or not.


Reply to this email directly or view it on GitHub
#5877 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar bluezeyes
bluezeyes - comment - 23 Jan 2015

The check works for me.
Manually pasted patch into com_languages/models/overwrite.php
Try to save keys named YES, NO, TRUE, FALSE, ON, OFF, NULL, NONE
(Maybe they should mentioned in this order in the message)

Result: Save process is canceled, Error Message was presented.

avatar zero-24 zero-24 - alter_testresult - 23 Jan 2015 - bluezeyes : Tested successfully
avatar zero-24 zero-24 - change - 23 Jan 2015
Category Language & Strings
avatar zero-24 zero-24 - change - 23 Jan 2015
The description was changed
Easy No Yes
avatar anibalsanchez anibalsanchez - test_item - 23 Jan 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 23 Jan 2015

@test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5877.
avatar brianteeman
brianteeman - comment - 23 Jan 2015

Thank you for correcting the string
On 23 Jan 2015 15:07, "Anibal Sanchez" notifications@github.com wrote:

@test https://github.com/test OK

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/5877
http://issues.joomla.org/tracker/joomla-cms/5877.


Reply to this email directly or view it on GitHub
#5877 (comment).

avatar zero-24 zero-24 - change - 23 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 23 Jan 2015

Moving to RTC Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5877.
avatar infograf768 infograf768 - change - 24 Jan 2015
Milestone Added:
avatar infograf768 infograf768 - close - 24 Jan 2015
avatar infograf768 infograf768 - reference | - 24 Jan 15
avatar infograf768 infograf768 - merge - 24 Jan 2015
avatar infograf768 infograf768 - close - 24 Jan 2015
avatar infograf768 infograf768 - change - 24 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-24 06:32:56
avatar infograf768 infograf768 - head_ref_deleted - 11 Feb 2015

Add a Comment

Login with GitHub to post a comment