? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
21 Jan 2015

When JLanguage parses files in debug mode, it adds a list of line numbers with errors to a string for reference. The SplFileObject starts with the first line as line 0, which means the line number displayed in the output is off by one. This PR adjusts it.

Test instructions:
1) Add this string to a language file temporarily: DASHBOARD.NEW.NOTIFICATION.COUNT_1="There is <span class="badge">1</span> new notification." (yes, this is a valid key and will display properly)
2) Enable language debug mode
3) In the debug output, note the line number that the error appears in; it should be off by one
4) Apply patch
5) Refresh page and re-check debug output

avatar mbabker mbabker - open - 21 Jan 2015
avatar jissues-bot jissues-bot - change - 21 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 21 Jan 2015
Category Language & Strings UI/UX
avatar zero-24 zero-24 - change - 21 Jan 2015
Easy No Yes
avatar brianteeman
brianteeman - comment - 21 Jan 2015

@test issue confirmed and patch resolves it


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5858.

avatar brianteeman brianteeman - test_item - 21 Jan 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 22 Jan 2015

@test
Works fine. Merging.

avatar infograf768 infograf768 - reference | fad1f1f - 22 Jan 15
avatar infograf768 infograf768 - merge - 22 Jan 2015
avatar infograf768 infograf768 - close - 22 Jan 2015
avatar infograf768 infograf768 - close - 22 Jan 2015
avatar infograf768 infograf768 - change - 22 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-22 08:06:45
avatar infograf768 infograf768 - change - 22 Jan 2015
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 22 Jan 2015

Add a Comment

Login with GitHub to post a comment